Re: newfs and mount vs. half-baked disks
From: Gordon Tetlow (gordont_at_gnf.org)
Date: 11/10/03
- Previous message: Bruce Evans: "Re: newfs and mount vs. half-baked disks"
- In reply to: Wes Peters: "Re: newfs and mount vs. half-baked disks"
- Next in thread: Garance A Drosihn: "Re: newfs and mount vs. half-baked disks"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 10 Nov 2003 09:16:18 -0800 To: Wes Peters <wes@softweyr.com>
On Thu, Nov 06, 2003 at 09:43:34AM -0800, Wes Peters wrote:
>
> I found an unused field called "fs_state" and used that, as Kirk
> suggested. Here's the new patch, which changes fsck to notice the
> fs_state and doesn't require re-writing all of the superblocks.
>
> This patch adds a -E (generate errors) option to fsck, causing fsck to
> exit at various stages or to otherwise leave the state of fs_state and
> fs_clean in other than pristine conditions. I will, of course, commit
> the -E changes separately from the fs_state changes.
>
> Thanks in advance for reviewing. And yes, I did manage to attach the
> patch this time. Doh!
After a cursory glance, a couple of nits. Perhaps ErrorFlag should be
Eflag to be consistent with the style of the rest of the source? Also,
your error reporting in fsck_ffs is fs.state != 0 is less than obvious:
"superblock %d is not finished" Perhaps it could be "superblock %d is in
an inconsistent state, this is probably due to a premature exit of newfs"
or some such message.
-gordon
- application/pgp-signature attachment: stored
- Previous message: Bruce Evans: "Re: newfs and mount vs. half-baked disks"
- In reply to: Wes Peters: "Re: newfs and mount vs. half-baked disks"
- Next in thread: Garance A Drosihn: "Re: newfs and mount vs. half-baked disks"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
- Re: poc zlib sploit just for fun :)
... Attached below is a patch RK and I whipped up yesterday, ... > sh-2.05b$
exit ... string-format vulnerability (in case something feeds '("Hello%c ...
there\n", '\0')' to gzprintf). ... (Bugtraq) - Re: mtime updates for mmapped files.
... calling a possibly sleeping function from atomic context - ... by this patch.
... My application calls "exit". ... and not really about my personal situation.
... (Linux-Kernel) - Re: [PATCH 2/6] 2.6.16-rc1 perfmon2 patch for review
... the patch is relative ... perfmon.c is a big source file. ...
I've seen this style of goto usage in the code a few times, ... Why are you jumping backwards
to the error exit? ... (Linux-Kernel) - Re: make -k does not exit with appropriate error code if errors are encountered
... Please review this patch that fixes this bug: ... by ignoring execution
when the command is a comment. ... but exit 0 if the specified targets are ...
(freebsd-arch) - [PATCH 1/3] kconfig and lxdialog, kernel 2.6.13.4
... The overall purpose of this patch is to add an "Abort" button to the ... didn't
actually want to exit kconfig). ... made to lxdialog. ... (Linux-Kernel)