Re: AoE for 4.x

From: Sam (sah_at_softcardsystems.com)
Date: 09/22/04

  • Next message: Sam: "Re: AoE for 4.x" 
    Date: Tue, 21 Sep 2004 19:21:59 -0500 (EST)
To: Julian Elischer <julian@elischer.org>

    > Sam wrote:
    >
    >>>
    >>>
    >>> I guess we are used to it.
    >>>
    >>> I can't recommend enough the utility of having a cvs mirror and using cvs
    >>> to keep your
    >>> work trees sync'd against FreeBSD. It is also a goodd way of making sure
    >>> that you don't
    >>> forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up all the
    >>> changed files.
    >>>
    >>
    >> And I can't thank you enough. I forgot about a few other (rather)
    >> important file changes this picked up.
    >>
    >> A patchfile for aoe against today's 4.10 source tree
    >> is at:
    >> http://www.coraid.com/support/freebsd/aoe.patch
    >>
    >> A few notes:
    >>
    >> The file sys/dev/aoe/aoe4bsd.dd is basic documentation for
    >> the driver.
    >>
    >> All references to chr major 200 will have to be changed to whatever
    >> gets assigned, obviously.
    >>
    >> The netisr selected in sys/net/netisr.h was picked at random. Is it
    >> OK?
    >>
    >> The label typeunknown in sys/net/if_ethersubr.c is added to give
    >> netgraph a chance to get the packets if AoE is not loaded. Appropriate?
    >>
    >> I dinna know how to fill out the copyright/license comment in the headers,
    >> but i gave it a shot. Thoughts here would be appreciated.
    >>
    >> TIA to all the curious eyes that skim the driver for glaring flaws.
    >
    > haven't read it yet, just skimmed..
    >
    > Very CLEAN looking code.. style(9) complient to a large extent..
    > (you do know about 'man 9 style' right?)

    Thanks - I didn't, but I do now. :)

    > now that it is written, this is the time to
    > go through it and write down everything that comes to mind in comments..
    > Everything that a person trying to decode the driver might want to know.
    > Including comments about the standards, tricky bits of code,
    > reasons you decided to do things in certain ways. etc.

    I tend towards the side that says you write a short paper
    about a chunk of code as comments can (and do) get out of
    sync. When in Rome, though ...

    I'll have to digest the style page a little more to see what
    types of comments are requested. I'm choking a bit on some
    of the other requirements.

    Sam

    _______________________________________________
    freebsd-arch@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-arch
    To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"

  • Next message: Sam: "Re: AoE for 4.x"

    Relevant Pages