Re: AoE for 4.x

From: Sam (sah_at_softcardsystems.com)
Date: 09/22/04

  • Next message: Sam: "Re: AoE for 4.x" 
    Date: Tue, 21 Sep 2004 19:21:59 -0500 (EST)
To: Julian Elischer <julian@elischer.org>

    > Sam wrote:
    >
    >>>
    >>>
    >>> I guess we are used to it.
    >>>
    >>> I can't recommend enough the utility of having a cvs mirror and using cvs
    >>> to keep your
    >>> work trees sync'd against FreeBSD. It is also a goodd way of making sure
    >>> that you don't
    >>> forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up all the
    >>> changed files.
    >>>
    >>
    >> And I can't thank you enough. I forgot about a few other (rather)
    >> important file changes this picked up.
    >>
    >> A patchfile for aoe against today's 4.10 source tree
    >> is at:
    >> http://www.coraid.com/support/freebsd/aoe.patch
    >>
    >> A few notes:
    >>
    >> The file sys/dev/aoe/aoe4bsd.dd is basic documentation for
    >> the driver.
    >>
    >> All references to chr major 200 will have to be changed to whatever
    >> gets assigned, obviously.
    >>
    >> The netisr selected in sys/net/netisr.h was picked at random. Is it
    >> OK?
    >>
    >> The label typeunknown in sys/net/if_ethersubr.c is added to give
    >> netgraph a chance to get the packets if AoE is not loaded. Appropriate?
    >>
    >> I dinna know how to fill out the copyright/license comment in the headers,
    >> but i gave it a shot. Thoughts here would be appreciated.
    >>
    >> TIA to all the curious eyes that skim the driver for glaring flaws.
    >
    > haven't read it yet, just skimmed..
    >
    > Very CLEAN looking code.. style(9) complient to a large extent..
    > (you do know about 'man 9 style' right?)

    Thanks - I didn't, but I do now. :)

    > now that it is written, this is the time to
    > go through it and write down everything that comes to mind in comments..
    > Everything that a person trying to decode the driver might want to know.
    > Including comments about the standards, tricky bits of code,
    > reasons you decided to do things in certain ways. etc.

    I tend towards the side that says you write a short paper
    about a chunk of code as comments can (and do) get out of
    sync. When in Rome, though ...

    I'll have to digest the style page a little more to see what
    types of comments are requested. I'm choking a bit on some
    of the other requirements.

    Sam

    _______________________________________________
    freebsd-arch@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-arch
    To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"

  • Next message: Sam: "Re: AoE for 4.x"

    Relevant Pages

    • Re: AoE for 4.x
      ... > Sam wrote: ... >> I decided to write a 4.x driver thinking it would a) be easier to port ... > I can't recommend enough the utility of having a cvs mirror and using cvs to ... netgraph a chance to get the packets if AoE is not loaded. ...
      (freebsd-arch)
    • Re: AoE for 4.x
      ... Sam wrote: ... >> I can't recommend enough the utility of having a cvs mirror and using ... > netgraph a chance to get the packets if AoE is not loaded. ... > TIA to all the curious eyes that skim the driver for glaring flaws. ...
      (freebsd-arch)
    • Re: Unidrv Minidriver for Win 9x??
      ... > Hi Sam, ... > Is this an NT 4.0 driver? ... the rendering dll is run in kernel mode. ... Then I opened WinDbg and attached to spoolsv.exe process. ...
      (microsoft.public.development.device.drivers)
    • Re: iwn driver on 7.1 [no vaps in RELENG_7]
      ... I do not know how far it is, but there is vap_releng7 in the sam perforce and projects/vap7 in svn on which Sam Leffler is actively working: http://lists.freebsd.org/pipermail/svn-src-projects/2009-January/thread.html ... OTOH iwn is now out of date and someone needs to update it. ... There's newer firmware that is supposed to fix many of the bugs I hit when I worked on the driver and obsd has added support for newer parts that people want. ...
      (freebsd-stable)
    • Re: Setup IBM DS 300 to a Windows 2003 server running on HS20
      ... Sam wrote: ... > Our company recently bought a new DS 300 with one single SCSI connecter ... Did you install the Windows 2003 driver for your SCSI interface? ... need the driver, and when you do the Win2K3 installation, you press the ...
      (comp.arch.storage)