Re: -I${CURDIR}/../../sys in src/*bin/Makefiles

From: Bruce Evans (bde_at_zeta.org.au)
Date: 03/26/05

  • Next message: Jun Kuriyama: "Re: Removing gtar from base"
    Date: Sat, 26 Mar 2005 15:08:22 +1100 (EST)
    To: Brooks Davis <brooks@one-eyed-alien.net>
    
    

    On Fri, 25 Mar 2005, Brooks Davis wrote:

    > In PR bin/79229 the submitter suggests that we add -I${CURDIR}/../../sys
    > to CFLAGS in sbin/ifconfig/Makefile. I initially responded that we
    > don't normally do that because buildworld handles picking up the latest
    > headers, but after greping other Makefiles in sbin, I found that we
    > do actually do that in a number of cases. It seems to me that we
    > should really make up our mind which one we should do. I'm somewhat
    > disinclined to add -I's to every utility, but that's not a strong
    > opinion. What do others thing?

    This is a bug in the other Makefiles. It is not needed for full builds,
    and breaks some cases for building just one utility (ones where libraries
    are consistent with <sys> but not with ${CURDIR}/../../sys, and the
    utility sources are either old so that they match <sys> or haven't
    changed so much that they need new system headers). It is just a hack
    that "fixes" a different set of cases (ones where the utility sources
    match ${CURDIR}/../../sys, and the installed libraries are either new
    so that they match ${CURDIR}/../../sys but not <sys> (unlikely) or
    haven't change so much that they don't work with utilities compiled
    with new system headers).

    I thought that ru fixed it. Well, that was a long time ago and the
    bug seems to be mainly in newer Makefiles. ps/Makefile was fixed in
    rev.1.14 (2001/05/18).

    Bruce
    _______________________________________________
    freebsd-arch@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-arch
    To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"


  • Next message: Jun Kuriyama: "Re: Removing gtar from base"

    Relevant Pages