[PATCH] Remove ENABLE_SSE option from i386 and pc98

From: Xin LI (delphij_at_frontfree.net)
Date: 07/01/05

  • Next message: Peter Edwards: "ktrace and KTR_DROP" 
    Date: Fri, 1 Jul 2005 19:11:03 +0800
To: freebsd-arch@FreeBSD.org, re@FreeBSD.org

    Hi,

    Here is a patch for review, which removes ENABLE_SSE from i386 and
    pc98 platforms. I think we should have it before we branch RELENG_6.

    The reason why the option should be removed:

            - ENABLE_SSE was turned on by default 2 years and 9 months
              ago, for I686_CPU. It makes few sense to "enable" something
              that is already enabled (No I586_CPUs supports SSE so far
              as I am aware)
            - We have DISABLE_SSE to disable SSE, having both ENABLE_SSE
              and DISABLE_SSE is quite confusing, since DISABLE_SSE
              always overrides ENABLE_SSE.

    Cheers, 

    -- 
Xin LI <delphij frontfree net>	http://www.delphij.net/
See complete headers for GPG key and other information.

  • Next message: Peter Edwards: "ktrace and KTR_DROP"

    Relevant Pages

    • Re: vnode(9) update
      ... >> by some people to ask arch@ for a review before making such change, ... Patch is attached with this mail. ... > good reason to axe it, ...
      (freebsd-arch)
    • Re: [PATCH] Remove ENABLE_SSE option from i386 and pc98
      ... Xin LI wrote: ... > Here is a patch for review, which removes ENABLE_SSE from i386 and ... > The reason why the option should be removed: ...
      (freebsd-arch)
    • Re: [PATCH] backlight dimmer
      ... now checkpatch.pl only complains about a missing signed-off-by. ... Is this ok for review? ... when going over your patch.. ... is there a reason you introduce yet ...
      (Linux-Kernel)
    • Re: How to improve the quality of the kernel?
      ... IMO we should concentrate more on preventing regressions than on fixing them. ... Over two years ago I've reviewed some _cleanup_ patch and noticed three bugs ... Ignore reviewers - fix the bugs but don't credit reviewers (crediting them ... review the patch than to make it so getting near to zero credit for review ...
      (Linux-Kernel)
    • Re: [patch] lockf(3) user-exploitable kernel panic
      ... I know my patch fails ... that libutil tries to provide this interface. ... The reason I asked was because I don't have access to many boxes of ... different architectures or operating systems. ...
      (freebsd-arch)