Re: FreeBSD/xbox: updated 7.0 patchset
From: M. Warner Losh (imp_at_bsdimp.com)
Date: 11/07/05
- Previous message: Rink Springer: "FreeBSD/xbox: updated 7.0 patchset"
- In reply to: Rink Springer: "FreeBSD/xbox: updated 7.0 patchset"
- Next in thread: Ed Schouten: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Reply: Ed Schouten: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Reply: Rink Springer: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sun, 06 Nov 2005 22:35:03 -0700 (MST) To: rink@stack.nl
In message: <20051106222359.GC46752@stack.nl>
Rink Springer <rink@stack.nl> writes:
: You can download the patches from
: http://rink.nu/downloads/xbox-patches/xbox-7-current.diff. I hope this
: patch will be committed to the FreeBSD source tree. Let me know any
: suggestions for improvements.
OK. I mostly like this patch. It is fairly clean and I'll be working
on integrating it into the FreeBSD repo, with your help.
I have just a few questions/comments on your patch.
First, options XBOX shouldn't be in opt_global.h, but rather in
opt_xbox.h that dev/fb/boot_font.c, i386/i386/machdep.c,
i386/i386/pmap.c, i386/i386/vm_machdep, i386/isa/clock.c, and
i386/pci/pci_cfgreg.c should be including. In general, we try to
reserve opt_global.h for really global stuff.
I don't understand the change to dev/fb/boot_font.c at all. Can you
explain it in more detail?
There's some style(9) issues with xboxfb.c. Specifically, there are a
few cases in some switches that are inconsistantly formatted wrt other
case statements.
There are a few really gross hacks that are marked with XXX better
fixes welcome. I'm a little torn about committing those, but at least
they are all #ifdef XBOX. My question is how long do you think until
there's a better solution for them?
This is absolutely great work! Don't let my few quibbles and such get
you down. I very much want to see xbox support committed to the tree.
Warner
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
- Previous message: Rink Springer: "FreeBSD/xbox: updated 7.0 patchset"
- In reply to: Rink Springer: "FreeBSD/xbox: updated 7.0 patchset"
- Next in thread: Ed Schouten: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Reply: Ed Schouten: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Reply: Rink Springer: "Re: FreeBSD/xbox: updated 7.0 patchset"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|