Re: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c

M. Warner Losh wrote:
: Peter Jeremy wrote:
: > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote:
: >> Log:
: >> Remove leading __ from __(inline|const|signed|volatile). They are
: >> obsolete. This should reduce diffs to NetBSD as well.
: >
: > Also, any diff reduction with NetBSD is probably outweighed by
: > the diff increase with other FreeBSD branches.
: >
: > Maybe this should be treated like whitespace cleanup - something to
: > do if you're going to be doing something non-trivial in the source
: > file. (There are probably other cleanups in the same category).

Would merging these to RELENG_6 help any? RELENG_5 is dead after this
release anyway...

FYI, cosmetic churn causes headaches for the Security Team: It means that
we have to produce lots of different patches for an issue rather than just
one patch. (And inevitably we don't notice that the patches won't apply
correctly until we're about to send out the advisory...)

Admittedly, this isn't a major concern, but it is certainly one reason to
make cosmetic changes at the same time as substantive changes rather than
separately.

Colin Percival

_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"

Relevant Pages