Re: SET, CLR, ISSET in types.h for _KERNEL builds

On Tuesday 27 June 2006 21:58, M. Warner Losh wrote:
NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined). I'd like to do something similar in FreeBSD. I see no
reason to needless deviate from NetBSD here. One could make an
argument for lots of different files, but at the end of the day does
it really matter enough to justify having it be different than NetBSD?

Here's my proposed diff, inline, for your consideration:

Index: types.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/types.h,v
retrieving revision 1.95
diff -u -r1.95 types.h
--- types.h 26 Nov 2005 12:42:35 -0000 1.95
+++ types.h 27 Jun 2006 19:57:23 -0000
@@ -294,6 +294,11 @@

#define offsetof(type, field) __offsetof(type, field)

+/* Macros to clear/set/test flags. */
+#define SET(t, f) (t) |= (f)
+#define CLR(t, f) (t) &= ~(f)
+#define ISSET(t, f) ((t) & (f))
+
#endif /* !_KERNEL */


I am currently expanding those macros in all the USB drivers I am rewriting.

--HPS
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • SET, CLR, ISSET in types.h for _KERNEL builds
    ... NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL ... I'd like to do something similar in FreeBSD. ... reason to needless deviate from NetBSD here. ... Here's my proposed diff, inline, for your consideration: ...
    (freebsd-arch)
  • Re: SET, CLR, ISSET in types.h for _KERNEL builds
    ... it really matter enough to justify having it be different than NetBSD? ... Here's my proposed diff, inline, for your consideration: ... I'd rather enclose the whole RHS of SET and CLR in parentheses. ...
    (freebsd-arch)
  • Re: is gzip(1) large file aware in 2.0?
    ... >> in Solaris. ... That is the reason I asked... ... > a multi-faceted animal like NetBSD... ... it looks really ugly running apps with 64-bit offset_t and others ...
    (comp.unix.bsd.netbsd.misc)
  • Re: SET, CLR, ISSET in types.h for _KERNEL builds
    ... reason to needless deviate from NetBSD here. ... it really matter enough to justify having it be different than NetBSD? ... Who not create abstract framework for work with bitmask more then 64bits ... static inline isset_bit{ ...
    (freebsd-arch)
  • Re: SET, CLR, ISSET in types.h for _KERNEL builds
    ... AL>> reason to needless deviate from NetBSD here. ... AL>> it really matter enough to justify having it be different than NetBSD? ... AL>> Here's my proposed diff, inline, for your consideration: ... AL>Who not create abstract framework for work with bitmask more then 64bits ...
    (freebsd-arch)
Quantcast