Re: New in-kernel privilege API: priv(9)


On Tue, 31 Oct 2006, Skip Ford wrote:

Robert Watson wrote:
Index: sys/contrib/altq/altq/altq_cdnr.c
===================================================================
RCS file: /zoo/cvsup/FreeBSD-CVS/src/sys/contrib/altq/altq/altq_cdnr.c,v
retrieving revision 1.2
diff -u -r1.2 altq_cdnr.c
--- sys/contrib/altq/altq/altq_cdnr.c 12 Jun 2004 00:57:20 -0000 1.2
+++ sys/contrib/altq/altq/altq_cdnr.c 30 Oct 2006 17:07:54 -0000
@@ -1262,7 +1262,9 @@
case CDNR_GETSTATS:
break;
default:
-#if (__FreeBSD_version > 400000)
+#if (__FreeBSD_versoin > 700000)
+ if ((error = priv_check(p, PRIV_ALTQ_MANAGE)) != 0)
+#elsif (__FreeBSD_version > 400000)
if ((error = suser(p)) != 0)
#else
if ((error = suser(p->p_ucred, &p->p_acflag)) != 0)

s/versoin/version/

...

Same thing.

Fixed in P4 and in my local CVS patch!

Thanks,

Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: Whats the point of __KERNEL_SYSCALLS__?
    ... retrieving revision 1.4 ... diff -u -p -r1.4 process.c ... -static int errno; ... * calls - which means inline code for fork too, ...
    (Linux-Kernel)
  • New Patch [was: Re: cvs rm sys/posix4 && enable sem]
    ... posix4/sched.h to sys/psched.h in this patch). ... "steps" as, in place of a repo-copy, I'll commit the diff to ... retrieving revision 1.2 ... +To compile this driver into the kernel, ...
    (freebsd-arch)
  • CONFIG_64_BIT
    ... retrieving revision 1.3 ... diff -u -p -r1.3 Kconfig ... config MMU ...
    (Linux-Kernel)
  • Re: vmstats entries type
    ... while updating the 64-bit per cpu counters. ... retrieving revision 1.80 ... diff -u -r1.80 vmstat.c ...
    (freebsd-current)
  • cvs rm sys/posix4 && enable sem
    ... diff -u -r1.265 Makefile ... retrieving revision 1.40 ... .Ft int ... +To compile this driver into the kernel, ...
    (freebsd-arch)