Re: sysconf(3) extensions.



On Thu, Dec 14, 2006 at 09:02:40AM +0800, Rong-en Fan wrote:
On 11/2/06, Pawel Jakub Dawidek <pjd@xxxxxxxxxxx> wrote:
On Wed, Nov 01, 2006 at 01:59:52PM -0600, Brooks Davis wrote:
On Wed, Nov 01, 2006 at 08:46:18PM +0100, Pawel Jakub Dawidek wrote:
On Wed, Nov 01, 2006 at 01:24:57PM -0600, Brooks Davis wrote:
On Wed, Nov 01, 2006 at 08:06:06PM +0100, Pawel Jakub Dawidek wrote:
Hi.

I'd like to add two non-standard value to the sysconf(3) functions,
which can be found in both Solaris and Linux: _SC_PHYS_PAGES and
_SC_AVPHYS_PAGES.

The patch is here:

http://people.freebsd.org/~pjd/patches/sysconf.patch

Can someone review it? Thanks.

What are they for? My concern is that _SC_AVPHYS_PAGES isn't going to
semantically match other platforms since in a steady state the free count
is small on FreeBSD, but on other systems it swings quite a bit based on
load.

_SC_PHYS_PAGES is used by libzpool (a part of the ZFS file system).
_SC_AVPHYS_PAGES I used more for completness.

OK. I'd be somewhat inclined to leave _SC_AVPHYS_PAGES out in that
case, but I don't feel strongly about it.

I've no opinion, I can remove it.

What's the status of _SC_PHYS_PAGES? I'm porting mbuffer [1], which
uses _SC_PHYS_PAGES.

I just committed it to HEAD.

--
Pawel Jakub Dawidek http://www.wheel.pl
pjd@xxxxxxxxxxx http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!

Attachment: pgpL4aGwtXxTJ.pgp
Description: PGP signature



Relevant Pages

  • Re: sysconf(3) extensions.
    ... I'd like to add two non-standard value to the sysconffunctions, ... The patch is here: ... Can someone review it? ... +to overflow. ...
    (freebsd-arch)
  • Re: sysconf(3) extensions.
    ... I'd like to add two non-standard value to the sysconffunctions, ... The patch is here: ... Can someone review it? ... +to overflow. ...
    (freebsd-arch)
  • Re: sysconf(3) extensions.
    ... I'd like to add two non-standard value to the sysconffunctions, ... The patch is here: ... Can someone review it? ... +to overflow. ...
    (freebsd-arch)
  • Re: sysconf(3) extensions.
    ... I'd like to add two non-standard value to the sysconffunctions, ... The patch is here: ... Can someone review it? ... +to overflow. ...
    (freebsd-arch)
  • Re: How to improve the quality of the kernel?
    ... IMO we should concentrate more on preventing regressions than on fixing them. ... Over two years ago I've reviewed some _cleanup_ patch and noticed three bugs ... Ignore reviewers - fix the bugs but don't credit reviewers (crediting them ... review the patch than to make it so getting near to zero credit for review ...
    (Linux-Kernel)