Re: [PATCH] Mantaining turnstile aligned to 128 bytes in i386 CPUs

On 16-Jan-2007 John Baldwin wrote:
On Tuesday 16 January 2007 11:51, Attilio Rao wrote:
The patch:
http://users.gufi.org/~rookie/works/patches/ts-sq/ts-sq.diff

Looks good. Some minor nits are that in subr_turnstile.c in the comment I
would say "a turnstile is allocated" rather than "a turnstile is got from a
specific UMA zone" as it reads a little bit clearer. Also, I would
say "Allocate a" rather than "Get a" for the two _alloc() functions. Also,
why not just use UMA_ALIGN_CACHE and make UMA_ALIGN_CACHE (128 - 1) on i386
and amd64 rather than adding a new UMA_ALIGN_SYNC?

Also, instead of calling bzero in the _init functions, I think you
could pass UMA_ZONE_ZINIT to uma_zcreate.

John
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"

Relevant Pages