Re: *at family of syscalls in FreeBSD



On Fri, Jun 08, 2007 at 10:56:38PM +0200, Dag-Erling Sm??rgrav wrote:
Roman Divacky <rdivacky@xxxxxxxxxxx> writes:
On Thu, Jun 07, 2007 at 05:56:39PM -0700, Eric Lemar wrote:
Obviously I prefer the wrapping, but I'm just a tad biased :)
well.. unless I hear some strong voice to change what I have I am not
changing it. it can always be changed in future.

I would strongly urge you to consider following Eric's suggestion; it is
conceptually far cleaner.

ok, that was the strong voice I wanted to hear :) the patch is here:

www.vlakno.cz/~rdivacky/linux_at.patch

changes:

I consistently use the mode of having

kern_foo() {
return kern_fooat(..., AT_FDCWD);
}

and kern_fooat() being the complete syscall calling the kern_get_at(). There is no
kern_common_foo() anymore.


the only comment from Eric now is the flags parameter but I don't think we should implement
it right now as we don't have any use for it so the patch is ok as it is. we will add the
flags parameter once we implement some functionality using it.

comments?

roman
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: TG3 doesnt work in kernel 2.4.27 (David S. Miller)
    ... With this patch, I can turn off autoneg on our b1600's switch and the ... 352-5299 voice ... and may not represent the views of Sun Microsystems, ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • [patch] wait_for_completion(_interruptible)?(_timeout)?
    ... Fixed up patch attached. ... 352-5299 voice ... Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: Cat 5e Telephone issues?
    ... have ran all the cat5e for phone and data into a patch panel. ... Then run the patch cables to the correct phone ports? ... Ie. this is designed for your voice and data to come in and get ...
    (comp.dcom.cabling)
  • Re: Beauty & The Beast Sound Issues
    ... > Can anyone help me out trying to figure out how to make the beast sound ... > "Beastly" through a theatre sound system, while saving his voice? ... Just patch it on an aux send on the ... If you don't know how to do this let me know what your mixer is ...
    (rec.arts.theatre.stagecraft)