Re: *at family of syscalls in FreeBSD
- From: Roman Divacky <rdivacky@xxxxxxxxxxx>
- Date: Sat, 9 Jun 2007 12:36:09 +0200
On Fri, Jun 08, 2007 at 10:56:38PM +0200, Dag-Erling Sm??rgrav wrote:
Roman Divacky <rdivacky@xxxxxxxxxxx> writes:
On Thu, Jun 07, 2007 at 05:56:39PM -0700, Eric Lemar wrote:
Obviously I prefer the wrapping, but I'm just a tad biased :)well.. unless I hear some strong voice to change what I have I am not
changing it. it can always be changed in future.
I would strongly urge you to consider following Eric's suggestion; it is
conceptually far cleaner.
ok, that was the strong voice I wanted to hear :) the patch is here:
www.vlakno.cz/~rdivacky/linux_at.patch
changes:
I consistently use the mode of having
kern_foo() {
return kern_fooat(..., AT_FDCWD);
}
and kern_fooat() being the complete syscall calling the kern_get_at(). There is no
kern_common_foo() anymore.
the only comment from Eric now is the flags parameter but I don't think we should implement
it right now as we don't have any use for it so the patch is ok as it is. we will add the
flags parameter once we implement some functionality using it.
comments?
roman
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"
- References:
- *at family of syscalls in FreeBSD
- From: Roman Divacky
- RE: *at family of syscalls in FreeBSD
- From: Eric Lemar
- Re: *at family of syscalls in FreeBSD
- From: Roman Divacky
- Re: *at family of syscalls in FreeBSD
- From: Doug Barton
- Re: *at family of syscalls in FreeBSD
- From: Roman Divacky
- RE: *at family of syscalls in FreeBSD
- From: Eric Lemar
- Re: *at family of syscalls in FreeBSD
- From: Roman Divacky
- RE: *at family of syscalls in FreeBSD
- From: Eric Lemar
- Re: *at family of syscalls in FreeBSD
- From: Roman Divacky
- Re: *at family of syscalls in FreeBSD
- From: Dag-Erling Smørgrav
- *at family of syscalls in FreeBSD
- Prev by Date: Re: *at family of syscalls in FreeBSD
- Next by Date: Re: New cpu_switch() and cpu_throw().
- Previous by thread: Re: *at family of syscalls in FreeBSD
- Next by thread: Re: *at family of syscalls in FreeBSD
- Index(es):
Relevant Pages
|
|