Re: Removing NET_NEEDS_GIANT: first patch



On Tuesday 24 July 2007 02:21:09 pm Robert Watson wrote:

On Tue, 24 Jul 2007, John Baldwin wrote:

On Tuesday 24 July 2007 06:17:45 am Robert Watson wrote:
Patch attached, and also available at this URL:

Possibly use mtx_assert() rather than KASSERT(mtx_owned()) in
nfs_syscalls.c?

Sounds good, I will make that change. I picked that new structure because
it
most closely matched what was there, and what was there required a KASSERT
because it combined a variable check with a lock check, but the new code
doesn't require that.

*nod* I'd figured as much. I'd of almost prefer that the previous code had
been:

if (!debug_mpsafenet)
mtx_assert(...)

FWIW.

--
John Baldwin
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: HA: Possible Threading problem with -CURRENT / MySQL?
    ... On Thursday 17 June 2004 09:07 am, Robert Watson wrote: ... >> It's not to be news maybe, ... > Ditto. ... > to me last night that this was something he thought John Baldwin was going ...
    (freebsd-current)
  • Re: rusage breakdown and cpu limits.
    ... On Tue, 29 May 2007, John Baldwin wrote: ... runtime and tick counts ... I have indirectly shown that this approach will not yield sufficient results by decreasing the scope of the sched lock in other ways. ... This would gate context switches in the same way that a global scheduler lock would, except not over as long of a period. ...
    (freebsd-arch)
  • Re: file locking.
    ... On Thu, 16 Aug 2007, John Baldwin wrote: ... I just introduced an extra flag so I could remove the race from dropping the lock inbetween operations and get an accurate count of how big the array needs to be. ... What's more troubling is the continued erosion of support for libkvm as it ... Well shaving off two pointers gets us into cacheline size for struct file which has some perf improvement. ...
    (freebsd-arch)
  • Re: 4.7 vs 5.2.1 SMP/UP bridging performance
    ... > John Baldwin writes: ... >> perhaps PII? ... but it might be faster than the lock. ...
    (freebsd-current)
  • Re: 4.7 vs 5.2.1 SMP/UP bridging performance
    ... > John Baldwin writes: ... >> perhaps PII? ... but it might be faster than the lock. ...
    (freebsd-current)