Re: CTF patch for testing/review

On Monday 22 March 2010 3:05:12 pm M. Warner Losh wrote:
In message: <20100322.125937.278730673160410010.imp@xxxxxxxxxx>
M. Warner Losh <imp@xxxxxxxxxx> writes:
: In message: <20100322172104.14234yawbsev0sw8@xxxxxxxxxxxxxxxxxxxxx>
: Alexander Leidinger <Alexander@xxxxxxxxxxxxx> writes:
: : Normally we use MK_xxx for things which are opt-in/opt-out. What about
: : using MK_xxx instead of ENABLE_CTF? If people are in favour of MK_xxx,
: : what should the xxx part look like?
:
: Normally we *TEST* MK_XXX for things which are opt-in/opt-out and
: require the user to say WITH_XXX or WITHOUT_XXX if they don't like the
: default (or want to ensure they get option XXX, even if we turn it off
: by default in the future). The default then gets encoded in
: bsd.own.mk, and permeates the FreeBSD build system since we include
: that everywhere, directly or indirectly.
:
: The problem is that bsd.own.mk is not included in sys.mk, nor should
: it be. That's why we have the hacky combination of WITH_CTF and
: NO_CTF that's there today.
:
: : Is bsd.kern.mk included in module builds too?
:
: Yes.

One last thing I should have said was that the patch that was posted
earlier in the thread looked ok, and likely couldn't be made
significantly better due to the bsd.own.mk issue.

I think the patch is a good approach, I just think it needs to default to not
enabling CTF by default. Instead, various bsd.foo.mk should selectively
enable it.

--
John Baldwin
_______________________________________________
freebsd-arch@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: CTF patch for testing/review
    ... and permeates the FreeBSD build system since we include ... That's why we have the hacky combination of WITH_CTF and ... One last thing I should have said was that the patch that was posted ... Sorry for the lame followup to my own post. ...
    (freebsd-arch)
  • Re: Detaching USB stick crashes BETA4/BETA5
    ... On Tue, 2004-09-21 at 20:36, M. Warner Losh wrote: ... I was able to get crash dump in the situation that looks similar to one ... I have some concerns about the patch, ... I can confirm that with this patch system does not crash no matter how ...
    (freebsd-current)
  • Re: Change to output
    ... "M. Warner Losh" writes: ... > Consider the following patch. ... iumop ap!sdn w,I idlaH ... To unsubscribe, ...
    (freebsd-arch)
  • Re: [PATCH] Please test: new ACPI release (20041105) import
    ... Warner Losh wrote: ... >>I have a patch in my tree to do this. ... My serial port. ...
    (freebsd-current)
  • Re: Fix for 5.2-BETA lockup problems
    ... : "M. Warner Losh" wrote: ... :>: Please try the attached patch which should fix it. ... First time since the hostcache code ...
    (freebsd-current)