Re: (re@) FIX: malloc(9)/free(9) confusion bug in netgraph

From: Julian Elischer (julian_at_elischer.org)
Date: 05/15/03

  • Next message: Robert Watson: "Re: (re@) FIX: malloc(9)/free(9) confusion bug in netgraph" 
    Date: Thu, 15 May 2003 11:06:06 -0700 (PDT)
To: Martin Blapp <mb@imp.ch>

    I found it..
    it's a wrong malloc type on a FREE()
    it only happens in shutting down the node in some cases so you shouldn't
    see it much.

    But here's the fix: (excuse cut'n'paste)

    re@, can I commit this fix?

    Index: ng_bridge.c
    ===================================================================
    RCS file: /home/ncvs/src/sys/netgraph/ng_bridge.c,v
    retrieving revision 1.18
    diff -u -r1.18 ng_bridge.c
    --- ng_bridge.c 19 Feb 2003 05:47:31 -0000 1.18
    +++ ng_bridge.c 15 May 2003 18:03:55 -0000
    @@ -987,7 +987,7 @@
            /* If node was shut down, this is the final lingering timeout */
            s = splnet();
            if (NG_NODE_NOT_VALID(node)) {
    - FREE(priv, M_NETGRAPH);
    + FREE(priv, M_NETGRAPH_BRIDGE);
                    NG_NODE_SET_PRIVATE(node, NULL);
                    NG_NODE_UNREF(node);
                    splx(s);

    On Thu, 15 May 2003, Martin Blapp wrote:

    >
    > This just happened after I exited from X and did a soft reboot.
    > Yes, vmware3 is installed with ng_bridgeing actived.
    >
    > Probably freeing with wrong type, but maybe not here
    >
    > panic()
    > free()
    > ng_bridge_timeout()
    > softclock()
    > ithread_loop()
    > fork_exit()
    >
    > Martin
    >
    > Martin Blapp, <mb@imp.ch> <mbr@FreeBSD.org>
    > ------------------------------------------------------------------
    > ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH
    > Phone: +41 61 826 93 00 Fax: +41 61 826 93 01
    > PGP: <finger -l mbr@freebsd.org>
    > PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E
    > ------------------------------------------------------------------
    > _______________________________________________
    > freebsd-current@freebsd.org mailing list
    > http://lists.freebsd.org/mailman/listinfo/freebsd-current
    > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
    >

    _______________________________________________
    freebsd-current@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-current
    To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

  • Next message: Robert Watson: "Re: (re@) FIX: malloc(9)/free(9) confusion bug in netgraph"

    Relevant Pages