Re: boot2 patch, please test.

From: Poul-Henning Kamp (phk_at_phk.freebsd.dk)
Date: 06/02/04

  • Next message: Søren Schmidt: "Re: atapi problems getting weirder and weirder" 
    To: John Baldwin <jhb@FreeBSD.org>
Date: Wed, 02 Jun 2004 09:54:53 +0200

    In message <200406011125.03166.jhb@FreeBSD.org>, John Baldwin writes:
    >On Saturday 29 May 2004 05:21 pm, Poul-Henning Kamp wrote:
    >> Some embedded boxes do not have the keyboard controller, and this
    >> patch adds a timeout so they do not get stuck waiting for it to
    >> become ready.
    >>
    >> Please test that this patch does not have any effect on normal
    >> PC architecture machines.
    >
    >I'd prefer that you explicitly set %cx to a timeout value after the cli
    >instead of relying on its value being zero in the caller.

    ENOMOREBYTES :-(

    I guess the logical thing would be to inline it rather than have it be
    a function, that saves the cx initializtion, the call and the return. 

    -- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
  • Next message: Søren Schmidt: "Re: atapi problems getting weirder and weirder"

    Relevant Pages

    • Re: boot2 patch, please test.
      ... > Some embedded boxes do not have the keyboard controller, ... > patch adds a timeout so they do not get stuck waiting for it to ... I'd prefer that you explicitly set %cx to a timeout value after the cli ...
      (freebsd-current)
    • Re: Unable to connect to wireless 802.11 AP with hidden SSID
      ... >> Did you have a chance to review the patch submitted by Rudolf? ... > add -t seconds option, so that the timeout is configurable, with the ... it was in the ISC code this was derived from (that's a different ... The current timeout may be a bit long, but gigabit nics and wireless ...
      (freebsd-current)
    • Re: [RFC patch 0/4] TSC calibration improvements
      ... It loops for a _very_ short timeout, but on the other hand it should also ... under virtualization, and the fast case will then fail early. ... the fast calibration failed in 4-5 reboots that i did ... I am assuming the patch you just sent was for 2.6.27. ...
      (Linux-Kernel)
    • Re: [git patches] libata fixes
      ... Applied this on top of 2.6.21-rc1 and your previous patch (see my previous ... ata9.00: qc timeout (cmd 0xef) ... failed to set xfermode ...
      (Linux-Kernel)
    • [PATCH] stopmachine: allow force progress on timeout
      ... Rusty Russell wrote: ... It is also why the default timeout ... If we don't want to handle this case, let's not apply any patch at all. ... +extern unsigned int stopmachine_force; ...
      (Linux-Kernel)