Re: vfs_syscalls / fhstatfs / suser()
From: Alfred Perlstein (alfred_at_freebsd.org)
Date: 06/07/04
- Previous message: Thomas Moestl: "Re: HEADS UP! KSE needs more attention"
- In reply to: Pawel Jakub Dawidek: "Re: vfs_syscalls / fhstatfs / suser()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 7 Jun 2004 07:57:50 -0700 To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
* Pawel Jakub Dawidek <pjd@FreeBSD.org> [040607 04:45] wrote:
> +>
> +>
> +> --- ./vfs_syscalls.c.orig Sun Jun 6 19:32:23 2004
> +> +++ ./vfs_syscalls.c Sun Jun 6 19:33:12 2004
> +> @@ -4128,11 +4128,6 @@ fhstatfs(td, uap)
> +> sp->f_flags = mp->mnt_flag & MNT_VISFLAGMASK;
> +> if ((error = VFS_STATFS(mp, sp, td)) != 0)
> +> return (error);
> +> - if (suser(td)) {
> +> - bcopy(sp, &sb, sizeof(sb));
> +> - sb.f_fsid.val[0] = sb.f_fsid.val[1] = 0;
> +> - sp = &sb;
> +> - }
> +> return (copyout(sp, uap->buf, sizeof(*sp)));
> +> }
>
> I'm not sure what the intention was, but I think we should probably
> change first suser() to suser_cred(td->td_ucred, PRISON_ROOT) as leave
> second one.
>
> PS. I'm CCing this to alfred@ who bring it from NetBSD.
That sounds right.
-- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
- Previous message: Thomas Moestl: "Re: HEADS UP! KSE needs more attention"
- In reply to: Pawel Jakub Dawidek: "Re: vfs_syscalls / fhstatfs / suser()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
