Re: duplicated/bad output from apm(8)

From: Maxime Henrion (mux_at_freebsd.org)
Date: 06/30/04

  • Next message: Bjoern A. Zeeb: "Re: [TROLL] ... please add some ascii art in the future"
    Date: Wed, 30 Jun 2004 21:56:49 +0200
    To: Niki Denev <nike_d@cytexbg.com>
    
    

    Niki Denev wrote:
    > It seems that one of the last few commits
    > to 'usr.sbin/apm/apm.c' introduced
    > an extra printf for the battery status output.
    > And the output is like this :
    >
    > Number of batteries: 1
    > Battery 0:
    > Battery status: Battery Status: charging
    > ^^^^^^^^^^^^^^^^^^^^^^^
    > This is extra
    >
    > here is the patch that i used to fix
    > the output for me and my precious X31 :)
    >
    > ----------------------------------------------------------------------------
    > --- usr.sbin/apm/apm.c.orig Wed Jun 30 22:26:28 2004
    > +++ usr.sbin/apm/apm.c Wed Jun 30 22:35:12 2004
    > @@ -226,7 +226,6 @@
    > if (ioctl(fd, APMIO_GETPWSTATUS, &aps) == -1)
    > continue;
    > printf("Battery %d:\n", i);
    > - printf("\tBattery status: ");
    > if (aps.ap_batt_flag <= 255 &&
    > (aps.ap_batt_flag &
    > APM_BATT_NOT_PRESENT)) {
    > printf("not present\n");

    Indeed. I just committed your patch, thanks!

    Cheers,
    Maxime
    _______________________________________________
    freebsd-current@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-current
    To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"


  • Next message: Bjoern A. Zeeb: "Re: [TROLL] ... please add some ascii art in the future"

    Relevant Pages

    • Re: duplicated/bad output from apm(8)
      ... : Niki Denev wrote: ... :> It seems that one of the last few commits ... :> an extra printf for the battery status output. ... I just committed your patch, ...
      (freebsd-current)
    • duplicated/bad output from apm(8)
      ... It seems that one of the last few commits ... an extra printf for the battery status output. ... Niki Denev ...
      (freebsd-current)
    • Re: duplicated/bad output from apm(8)
      ... :: Niki Denev wrote: ... ::> It seems that one of the last few commits ... ::> an extra printf for the battery status output. ... I just committed your patch, ...
      (freebsd-current)
    • Re: [PATCH] Add support for power_supply on tosa
      ... Thanks for the patch and sorry for the delayed review. ... Say Y to enable support for the battery on the OLPC laptop. ... Because scheduled work doing tosa_bat_updatefor both ...
      (Linux-Kernel)
    • Re: [PATCH] Please test: new ACPI release (20041105) import
      ... Mark Santcroos wrote: ... The patch applies fine but it sill doesn't fix two long standing bugs:/ ... The secong bug is relatted to battery. ...
      (freebsd-current)