Re: duplicated/bad output from apm(8)

From: M. Warner Losh (imp_at_bsdimp.com)
Date: 06/30/04

  • Next message: M. Warner Losh: "Re: duplicated/bad output from apm(8)"
    Date: Wed, 30 Jun 2004 14:47:17 -0600 (MDT)
    To: mux@FreeBSD.org
    
    

    In message: <20040630195649.GB9228@elvis.mu.org>
                Maxime Henrion <mux@FreeBSD.org> writes:
    : Niki Denev wrote:
    : > It seems that one of the last few commits
    : > to 'usr.sbin/apm/apm.c' introduced
    : > an extra printf for the battery status output.
    : > And the output is like this :
    : >
    : > Number of batteries: 1
    : > Battery 0:
    : > Battery status: Battery Status: charging
    : > ^^^^^^^^^^^^^^^^^^^^^^^
    : > This is extra
    : >
    : > here is the patch that i used to fix
    : > the output for me and my precious X31 :)
    : >
    : > ----------------------------------------------------------------------------
    : > --- usr.sbin/apm/apm.c.orig Wed Jun 30 22:26:28 2004
    : > +++ usr.sbin/apm/apm.c Wed Jun 30 22:35:12 2004
    : > @@ -226,7 +226,6 @@
    : > if (ioctl(fd, APMIO_GETPWSTATUS, &aps) == -1)
    : > continue;
    : > printf("Battery %d:\n", i);
    : > - printf("\tBattery status: ");
    : > if (aps.ap_batt_flag <= 255 &&
    : > (aps.ap_batt_flag &
    : > APM_BATT_NOT_PRESENT)) {
    : > printf("not present\n");
    :
    : Indeed. I just committed your patch, thanks!

    But it wasn't surpurflous.

    Warner
    _______________________________________________
    freebsd-current@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-current
    To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"


  • Next message: M. Warner Losh: "Re: duplicated/bad output from apm(8)"

    Relevant Pages

    • Re: duplicated/bad output from apm(8)
      ... :: Niki Denev wrote: ... ::> It seems that one of the last few commits ... ::> an extra printf for the battery status output. ... I just committed your patch, ...
      (freebsd-current)
    • Re: duplicated/bad output from apm(8)
      ... > It seems that one of the last few commits ... > an extra printf for the battery status output. ... I just committed your patch, ...
      (freebsd-current)
    • duplicated/bad output from apm(8)
      ... It seems that one of the last few commits ... an extra printf for the battery status output. ... Niki Denev ...
      (freebsd-current)
    • Re: [PATCH] Add support for power_supply on tosa
      ... Thanks for the patch and sorry for the delayed review. ... Say Y to enable support for the battery on the OLPC laptop. ... Because scheduled work doing tosa_bat_updatefor both ...
      (Linux-Kernel)
    • Re: whomto.pl -- finding out whom to send patches to
      ... > I've written this perl script that takes a patch as input and prints the ... > authors/committers of the affected lines, using git-blame as the back end. ... > commits when a newer one is found, so we currently possibly take into ... > account more than just the last patch to touch a line. ...
      (Linux-Kernel)