Re: 5.3 IPSEC broken

From: Bjoern A. Zeeb (bzeeb-lists_at_lists.zabbadoz.net)
Date: 09/26/04

  • Next message: Benjamin Lutz: "Re: USB memory stick hotswap problems"
    Date: Sat, 25 Sep 2004 23:50:13 +0000 (UTC)
    To: Sam Leffler <sam@errno.com>
    
    

    On Sat, 25 Sep 2004, Sam Leffler wrote:

    > > > That's a 216 byte packet, fwiw. I instrumented key.c and ran into the
    > > > following ENOBUFS case on key.c:6957:
    > > >
    > > > /* align the mbuf chain so that extensions are in contiguous
    > > > region. */ error = key_align(m, &mh);
    > > > if (error)
    > > > return error;
    > > >
    > > > if (m->m_next) { /*XXX*/
    > > > m_freem(m);
    > > > return ENOBUFS;
    > > > }
    > > >
    > > > I.e., the author knew it was a bug (feature) that an additional mbuf
    > > > couldn't be handled here, but we do need to handle one. Looks like much
    > > > of the surrounding code could be replaced with a call to m_defrag()
    > > > and/or m_pullup().
    > >
    > > Just to mention that i too experience this problem,
    > > but with FAST_IPSEC so this probably means that if any fix will be made for
    > > netkey/key.c then netipsec/key.c will need it too.(as far as i can tell)
    > > Please correct me if i'm wrong.
    >
    > Correct. I gave Robert a fix that was sent to me for fast ipsec. I was going
    > to commit it this weekend after some testing.

    could you perhaps post it or place it somewhere for download ?

    -- 
    Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
    _______________________________________________
    freebsd-current@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-current
    To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
    

  • Next message: Benjamin Lutz: "Re: USB memory stick hotswap problems"

    Relevant Pages

    • Re: 5.3 IPSEC broken
      ... Sam Leffler writes: ... >> could you perhaps post it or place it somewhere for download? ... > FreeBSD src repository ...
      (freebsd-current)
    • Re: Recent ifconfig changes choke on fwip
      ... On Fri, 10 Dec 2004, Sam Leffler wrote: ... :I don't have any firewire devicesto test with. ... :to pickup this one. ... To unsubscribe, ...
      (freebsd-current)
    • Re: DWL AG530
      ... On Fri, 24 Sep 2004, Sam Leffler wrote: ... You can try to use the patchset at ... FreeBSD store.comicsmash.com 5.3-BETA6 ... To unsubscribe, ...
      (freebsd-current)
    • Re: DWL AG530
      ... On Fri, 24 Sep 2004, Sam Leffler wrote: ... You can try to use the patchset at ... FreeBSD store.comicsmash.com 5.3-BETA6 ... To unsubscribe, ...
      (freebsd-current)
    • Re: malloc bugs with tcpdump
      ... Sam Leffler wrote: ... > I sent the attached patch upstream to the tcpdump folks. ... Once I hear back I'll commit it. ... > retrieving revision 1.1.1.10 ...
      (freebsd-current)