Re: We have a lot of duplicated code in the kernel

From: Poul-Henning Kamp (phk_at_phk.freebsd.dk)
Date: 01/29/05

  • Next message: Xin LI: "Re: We have a lot of duplicated code in the kernel" 
    To: Alexander Leidinger <Alexander@Leidinger.net>
Date: Sat, 29 Jan 2005 16:21:28 +0100

    In message <20050129161022.0de822fe@Magellan.Leidinger.net>, Alexander Leidinger writes:
    >Hi,
    >
    >http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k)
    >contains a log of duplicated code in /sys (-current as of today). The
    >file starts with files with 20 consecutive lines of duplicated code and
    >ends with two files which share 1108 lines of code.
    >
    >If I let the program detect 6 consecutive lines of duplicated code, it
    >is also able to detect possible code reuse in the same file, but it also
    >prints a lot of "noise" then.
    >
    >I've filtered the list for some false positives (twa_fwimg, trlld?m,
    >if_patm_rtables), if someone else notices some more files please tell me
    >about them and I add them to the filter.

    And we'll soon see the tool which generates this in src/tools/tools
    somewhere I hope ? :-) 

    -- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
  • Next message: Xin LI: "Re: We have a lot of duplicated code in the kernel"

    Relevant Pages

    • Re: We have a lot of duplicated code in the kernel
      ... > If I let the program detect 6 consecutive lines of duplicated code, ... > about them and I add them to the filter. ... Could you regenerate the list w/o the MD code, ... turn up a couple of "easy to fix" cases of shared code. ...
      (freebsd-current)
    • Re: We have a lot of duplicated code in the kernel
      ... Alexander Leidinger: ... >If I let the program detect 6 consecutive lines of duplicated code, ... >about them and I add them to the filter. ... adapters, I am sure, code would have more than 50% of the same code. ...
      (freebsd-current)
    • We have a lot of duplicated code in the kernel
      ... contains a log of duplicated code in /sys. ... I've filtered the list for some false positives (twa_fwimg, trlld?m, ... about them and I add them to the filter. ... It is easier to fix Unix than to live with NT. ...
      (freebsd-current)