Re: patch: fix 30 second hang while resuming

From: Anish Mistry (mistry.7_at_osu.edu)
Date: 03/04/05

  • Next message: Anish Mistry: "Re: patch: fix 30 second hang while resuming" 
    To: freebsd-current@freebsd.org
Date: Fri, 4 Mar 2005 16:55:09 -0500

    On Sunday 27 February 2005 06:12 pm, Nate Lawson wrote:
    > Nate Lawson wrote:
    > > My system hangs a long time in ata_generic_reset() while
    > > resuming. I did some hunting and found that the loop was running
    > > for the full 310 * 100 ms (31 seconds). The bug is that the loop
    > > never exits when mask goes to 0 even though this is a termination
    > > condition (see end of the loop where the code masks off 1 and 2).
    > >
    > > The attached patch fixes this by exiting when the mask is set to
    > > 0 instead of looping the full 31 seconds. This is correct since
    > > setting the mask to 0 is how the loop marks master/slave "done".
    > > It also has a minor whitespace fix.
    >
    > Apologies, the last patch was not quite right. You need to check
    > that both status values are not "busy" as well as the mask. This
    > check could be merged in elsewhere as well. This was just a
    > convenient place to put it.
    >
    > Please use the attached patch instead.
    This works well for me. Is this going to be committed? 

    -- 
Anish Mistry

  • Next message: Anish Mistry: "Re: patch: fix 30 second hang while resuming"

    Relevant Pages

    • Re: PATCH - updated EC driver
      ... Nate Lawson wrote: ... It fixes numerous races and the broken tsleep ... > experimental burst mode support I had included in the last patch. ...
      (freebsd-current)
    • Re: powerd adaptive mode latching
      ... Nate Lawson wrote: ... Please test the patch. ... has duplicated cpufreq states to commit it to -current. ...
      (freebsd-current)
    • Re: ACPI mpsafe patch for testing
      ... Nate Lawson wrote: ... > Attached is the latest patch for running ACPI mpsafe. ... > pretty well tested and is ready for wider testing. ... I've put the patch up at this url since the list appears to strip ...
      (freebsd-current)
    • Re: libfetch ftp patch for less latency
      ... Nate Lawson writes: ... Add my patch -- if a server returns an error, I see no way it would ... have changed the PWD. ...
      (freebsd-current)
    • Re: patch: fix 30 second hang while resuming
      ... On Sunday 27 February 2005 06:12 pm, Nate Lawson wrote: ... I did some hunting and found that the loop was running ... the last patch was not quite right. ...
      (freebsd-current)