Re: Patch for sysinstall wrong-disc problem
From: John Baldwin (jhb_at_FreeBSD.org)
Date: 06/27/05
- Previous message: John Baldwin: "Re: 6.0-current panic: loading radeon module"
- In reply to: Doug White: "Patch for sysinstall wrong-disc problem"
- Next in thread: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Reply: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Reply: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: freebsd-current@freebsd.org Date: Mon, 27 Jun 2005 17:01:43 -0400
On Saturday 18 June 2005 08:33 pm, Doug White wrote:
> Hey folks,
>
> I've come up with a patch that fixes sysinstall prompting for the wrong CD
> when trying to install packages from non-CDROM media. Patch is here:
>
> http://people.freebsd.org/~dwhite/patches/index.c.20050618.patch
>
> This makes the "This is disc#0; I need disc#1" type message go away by
> checking if the install media is a CDROM first. Tested with an install
> over NFS, but it shouldn't make a difference what install media as long as
> its not a CD.
>
> I'll commit this shortly if there are no objections.
Just a suggestion: it might be a shorter patch with no need to reindent a
bunch of code if you change the patch to just add
if (mediaDevice->type != DEVICE_TYPE_CDROM)
return (DITEM_FAILURE);
before the while loop.
-- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
- Previous message: John Baldwin: "Re: 6.0-current panic: loading radeon module"
- In reply to: Doug White: "Patch for sysinstall wrong-disc problem"
- Next in thread: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Reply: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Reply: Doug White: "Re: Patch for sysinstall wrong-disc problem"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
