Re: dhclient/wpa_supplicant patch

From: Brooks Davis (brooks_at_one-eyed-alien.net)
Date: 06/29/05

  • Next message: Mike Silbersack: "mbuf trash-related "memory modified after free" panic fixed." 
    Date: Wed, 29 Jun 2005 00:23:38 -0700
To: Darren Pilgrim <dmp@bitfreak.org>

    On Tue, Jun 28, 2005 at 10:54:15PM -0700, Darren Pilgrim wrote:
    > From: Brooks Davis
    > >
    > > --- rc.d/wpa_supplicant Tue Jun 28 22:24:18 2005
    > > +++ rc.d/wpa_supplicant Tue Jun 28 18:51:32 2005
    > <...>
    > > +if ! wpaif $ifn; then
    > > + return 1
    > > +fi
    >
    > I think it would be better if the dhcpif/wpaif test is contained within
    > netif. It has to exist in netif because its job is to determine how to
    > configure the interface. The dhclient and wpa_supplicant scripts should
    > be "dumb" single-task scripts to start/stop their respective clients.
    >
    > By putting the dhcpif/wpaif test in the dhclient/wpa_supplicant scripts,
    > not only is it redundant, it makes it impossible to use the scripts
    > manually with an interface that isn't configured in /etc/rc.conf with
    > the DHCP or WPA magic words. Such manual operations are useful in
    > testing, temporary interfaces and custom profile-based configurations
    > where it's not possible/practical to have a configuration line in
    > /etc/rc.conf beforehand.

    Good point. The test is already in ifconfig_up/down so it's not needed
    in wpa_supplicant or dhclient.

    -- Brooks 

    -- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

  • Next message: Mike Silbersack: "mbuf trash-related "memory modified after free" panic fixed."