Re: Acquiring lockmgr lock "ufs" with non-sleepable locks

From: Andreas Tobler (toa_at_pop.agri.ch)
Date: 06/30/05

  • Next message: Suleiman Souhlal: "Re: Acquiring lockmgr lock "ufs" with non-sleepable locks" 
    Date: Thu, 30 Jun 2005 18:54:01 +0200
To: Suleiman Souhlal <ssouhlal@FreeBSD.org>

    Hello Suleiman,

    Suleiman Souhlal wrote:

    >>> This was introduced by my commit to take out the various kqueue
    >>> operations outside of ufs. It is because we are trying to lock the
    >>> vnode while holding the knlist mutex. I'll work on a fix on
    >>> wednesday, as I'll unfortunately be a bit busy until then. I hope
    >>> this won't cause you any inconvenience.
    >>>
    >>
    >> Is the below the same ?
    >
    >
    > Yes.
    >
    >> No, I did not try the follow-up patch yet.
    >
    >
    > The patch should fix it. I'll commit it as soon as I get approval.

    It did :) Thanks. The tail -f file works now.

    Though, I took the latest diff from your site
    (knlist_locking-20050629-2.diff) and had to add the thing below, you
    forgot a NULL in knlist_init.

    Regards,
    Andreas

    (p.s: patch hand edited)

    Index: src/sys/cam/scsi/scsi_target.c
    ===================================================================
    --- src/sys/cam/scsi/scsi_target.c (revision 187)
    +++ src/sys/cam/scsi/scsi_target.c (working copy)
    @@ -196,7 +196,7 @@
              TAILQ_INIT(&softc->work_queue);
              TAILQ_INIT(&softc->abort_queue);
              TAILQ_INIT(&softc->user_ccb_queue);
    - knlist_init(&softc->read_select.si_note, &softc->mtx);
    + knlist_init(&softc->read_select.si_note, &softc->mtx, NULL, NULL, NULL);

              return (0);
      }
    _______________________________________________
    freebsd-current@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-current
    To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

  • Next message: Suleiman Souhlal: "Re: Acquiring lockmgr lock "ufs" with non-sleepable locks"

    Relevant Pages