Re: biodone panics

From: Alex Lyashkov (shadow_at_psoft.net)
Date: 09/29/05

  • Next message: Don Lewis: "Re: stress test deadlock involving vm and/or geom" 
    To: Peter Edwards <peadar.edwards@gmail.com>
Date: Thu, 29 Sep 2005 10:17:13 +0300

    >
    > > biodone(struct bio *bp)
    > > {
    > > void (*done)(struct bio *);
    > >
    > > mtx_lock(&bdonelock);
    > > bp->bio_flags |= BIO_DONE;
    > > done = bp->bio_done
    > > if (done == NULL)
    > > wakeup(bp);
    > > mtx_unlock(&bdonelock);
    > > if (done != NULL)
    > > bp->bio_done(bp);
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    posible it should be
    if(done != NULL)
            done(bp);
    ?
    > > }
    >
    > Anyone agree?
    > _______________________________________________ 

    -- 
FreeVPS Developers Team  http://www.freevps.com
Positive Software        http://www.psoft.net
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
  • Next message: Don Lewis: "Re: stress test deadlock involving vm and/or geom"