Re: Cleanup for config(8)



On Fri, Dec 30, 2005 at 01:01:55AM -0500, Matt Emmerton wrote:
> Hi,
>
> I've put together some patches to clean up some "loose ends" in the
> config(8) code.
> Detailed notes and patches are located here:
> http://www.gsicomp.on.ca/projects/freebsd/config.html
>
> Comments, criticisms and committers welcome.
>
I've committed first patch almost intact.

I've committed second patch with the following modifications
except style:

- finddev() and findopt() return a pointer; also use them in
rmdev() and rmopt().

- didn't drop the "mandatory" directive; it's trivially
implemented, someone may use it, and there's generally no
sense in breaking API.

- didn't commit a bug: in mkmakefile.c, "goto nextparam" should
always be called regardless of whether DEVDONE was already set
or not.


Cheers,
--
Ruslan Ermilov
ru@xxxxxxxxxxx
FreeBSD committer

Attachment:pgp1gAx9e2NsJ.pgp
Description: PGP signature



Relevant Pages

  • Re: Improving the handling of PR:s
    ... In cases where such patches are correct/good enough, the non-application of those patches have what I believe to be significant effects. ... weekly email of "PRs recommended by the bugbuster team" ... This group of people could either be a self-proclaimed group of volunteers, or perhaps a group of people satisfying the criteria of "guy we kinda trust to do testing and provide a useful indication of sanity and correctness, but not with a commit bit". ... affirming that they have tested it could be automatically prioritized for committers to deal with, and there will be a clear and systematic record of what testing was done, and by who. ...
    (freebsd-current)
  • Re: [PATCH] mouse.4: cuaa0 renamed to cuad0
    ... Anyone of the 300+ committers ... phk should have ... Then why post non-critical documentation patches to an extremely busy ...
    (freebsd-current)
  • Cleanup for config(8)
    ... I've put together some patches to clean up some "loose ends" in the ... Detailed notes and patches are located here: ... Comments, criticisms and committers welcome. ...
    (freebsd-current)