Re: [patch] giant-less quotas
- From: Kostik Belousov <kostikbel@xxxxxxxxx>
- Date: Fri, 28 Apr 2006 10:36:00 +0300
On Thu, Apr 27, 2006 at 04:52:14PM -0400, Mike Jakubik wrote:
Kostik Belousov wrote:
I have developed patch to make ufs quota code working without
Giant, i.e. properly lock dquot and all around.
You can find the patch and description of the changes at
http://kostikbel.narod.ru. Please, review.
Is it possible to effectively test this on a UP kernel? I don't have any
SMP capable machines available.
I think it shall be tested both on UP and SMP machines. So, yes,
UP testing (presumably, with PREEMPTION) is useful.
Please, wait a short time for new patch. Current patch has two issues:
1. recent BO_NEEDSGIANT changes prevent patch from applying. I need
to do a merge.
2. I have fixed deadlock that appears when shapshot is taken
on quota-enabled fs (this deadlock is specific to my patch).
Supposely, this is problem reported by Kris Kennaway.
Attachment:
pgpGEaTMuolAI.pgp
Description: PGP signature
- References:
- Re: [patch] giant-less quotas
- From: Mike Jakubik
- Re: [patch] giant-less quotas
- Prev by Date: Re: -current buildkernel error
- Next by Date: panic: _mtx_lock_sleep: recursed on non-recursive mutex pmap
- Previous by thread: Re: [patch] giant-less quotas
- Next by thread: Re: nve0: device timeout (1)
- Index(es):
Relevant Pages
- Re: How to improve the quality of the kernel?
... IMO we should concentrate more on preventing regressions than on fixing them. ...
Over two years ago I've reviewed some _cleanup_ patch and noticed three bugs ... Ignore
reviewers - fix the bugs but don't credit reviewers (crediting them ... review the
patch than to make it so getting near to zero credit for review ... (Linux-Kernel) - Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24
... I was about to post v2 of my patch to avoid port space collisions with the native stack.
... I've tried to solicit review on it, but I think folks are reluctant... ... Pradeep's
IPoIB CM support for devices that don't have SRQs. ... Certainly we want to fix
this ... (Linux-Kernel) - Re: How to improve the quality of the kernel?
... There are not so simple cases like big infrastructure patches with ... "If the
patch introduces a new regression" ... review the patch than to make it so
getting near to zero credit for review ... (Linux-Kernel) - Re: new ARP code review
... L>> Q> Please review my new ARP patch and send me your feedbacks. ...
L>> and I will try to find a free time to review your patch again. ... This lookup
returns us the hardware address that this IP ... (freebsd-net) - Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch]
... The changelog in your earlier "Clustering indirect blocks in Ext3" ... patch
was good. ... Here's a quick low-levelish nitpickingish implementation review. ...
user-hostile BUG. ... (Linux-Kernel)