Re: bge(4) on BCM 5752 A02 panic due to media autoselect

Pyun YongHyeon wrote:
On Thu, Aug 31, 2006 at 11:24:55AM +0800, LI Xin wrote:
> David Christensen wrote:
> >> Recently one of my colleagues found that BCM 5752 A02 on Dell Latitude
> >> D820 would get "panic: invalid ife->ifm_data (0xa) in
> >> mii_phy_setmedia".
> >> After some investigation I have found that removing BCMR_ANEG from
> >> mii_capabilities in ukphy.c would work around the problem,
> >> and it turns
> >> out that without explicitly specifying media type, the code
> >> will finally
> >> get to pass the "intentionally invalid index" to mii_phy_setmedia and
> >> trigger an assertion fail.
> >>
> >> I have not tested the situation in -STABLE yet, but it was
> >> said to work
> >> there, though. Is there anyone can shed some light to me about how to
> >> debug the issue? Thanks in advance!
> >>
> >> PS. During the debugging I have found that the attached patch can make
> >> "bge0: firmware handshake timeout" issue disappear from the said chip.
> >> Because I do not have Broadcom specification at hand I would
> >> like to see
> >> if there is someone to give appropriate review for it.
> >
> > Try the attached patch instead and let me know if it works. When
> > FastBoot
> > is enabled on supported Broadcom controllers it allows the controller to
> > skip rereading firmware after a reset, allowing the driver to complete
> > its initialization more quickly. The Linux driver specifically disables
> > FastBoot because it performs some read/write tests to controller memory,
> > potentially corrupting the firmware, so FastBoot is disabled to insure
> > an
> > error free firmware reload. We don't do the same test so the same
> > change
> > isn't necessary. The patch happens to work because the bge driver
> > doesn't
> > perform firmware synchronization correctly, and the firmware initializes
> > too fast for the driver.
>
> Thank you for the patch. I have just tested the patch under
> FreeBSD/i386 -CURRENT and the I can confirm that the firmware timeout
> goes away. Will you please commit it?
>
> (Note that the panic still persists, I will try to get brgphy attach to
> see if things changes).
>

It would be great if you can test the brgphy patch. I'll commit the
patch if it work on your box.

Sure, I would be more than happy to do that. Which brgphy patch do you
want me to test? (I have patched brgphy.c and miidevs to make BCM5752
to attach as brgphy and it resolved the panic, but I am not quite sure
if that is what you want, though)

The attached patch is what I have tested on Dell D820 with BCM 5752 A2
chip, and it seems to work well.

Please let me know if you want additional tests for whatever patch.

Cheers,
--
Xin LI <delphij@xxxxxxxxxxx> http://www.delphij.net/
FreeBSD - The Power to Serve!
Index: bge/if_bge.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
retrieving revision 1.140
diff -u -r1.140 if_bge.c
--- bge/if_bge.c 24 Aug 2006 14:41:16 -0000 1.140
+++ bge/if_bge.c 31 Aug 2006 03:00:43 -0000
@@ -2326,6 +2326,12 @@
}
}

+ /*
+ * Write the magic number to the firmware mailbox at 0xb50
+ * so that the driver can synchronize with the firmware
+ */
+ bge_writemem_ind(sc, BGE_SOFTWARE_GENCOMM, BGE_MAGIC_NUMBER);
+
/* Issue global reset */
bge_writereg_ind(sc, BGE_MISC_CFG, reset);

@@ -2362,11 +2368,6 @@
CSR_WRITE_4(sc, BGE_MARB_MODE, BGE_MARBMODE_ENABLE);

/*
- * Prevent PXE restart: write a magic number to the
- * general communications memory at 0xB50.
- */
- bge_writemem_ind(sc, BGE_SOFTWARE_GENCOMM, BGE_MAGIC_NUMBER);
- /*
* Poll the value location we just wrote until
* we see the 1's complement of the magic number.
* This indicates that the firmware initialization
Index: bge/if_bgereg.h
===================================================================
RCS file: /home/ncvs/src/sys/dev/bge/if_bgereg.h,v
retrieving revision 1.52
diff -u -r1.52 if_bgereg.h
--- bge/if_bgereg.h 23 Aug 2006 11:32:54 -0000 1.52
+++ bge/if_bgereg.h 31 Aug 2006 03:02:00 -0000
@@ -1768,10 +1768,11 @@
} while(0)

/*
- * This magic number is used to prevent PXE restart when we
- * issue a software reset. We write this magic number to the
- * firmware mailbox at 0xB50 in order to prevent the PXE boot
- * code from running.
+ * This magic number is written to the firmware mailbox at 0xb50
+ * before a software reset is issued. After the internal firmware
+ * has completed its initialization it will write the opposite of
+ * this value, ~BGE_MAGIC_NUMBER, to the same location, allowing
+ * the driver to synchronize with the firmware.
*/
#define BGE_MAGIC_NUMBER 0x4B657654

Index: mii/brgphy.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/mii/brgphy.c,v
retrieving revision 1.45
diff -u -r1.45 brgphy.c
--- mii/brgphy.c 23 Aug 2006 15:37:07 -0000 1.45
+++ mii/brgphy.c 31 Aug 2006 03:27:03 -0000
@@ -107,6 +107,7 @@
MII_PHY_DESC(xxBROADCOM, BCM5704),
MII_PHY_DESC(xxBROADCOM, BCM5705),
MII_PHY_DESC(xxBROADCOM, BCM5750),
+ MII_PHY_DESC(xxBROADCOM, BCM5752),
MII_PHY_DESC(xxBROADCOM, BCM5714),
MII_PHY_DESC(xxBROADCOM, BCM5780),
MII_PHY_DESC(xxBROADCOM, BCM5706C),
@@ -607,6 +608,7 @@
bcm5704_load_dspcode(sc);
break;
case MII_MODEL_xxBROADCOM_BCM5750:
+ case MII_MODEL_xxBROADCOM_BCM5752:
case MII_MODEL_xxBROADCOM_BCM5714:
case MII_MODEL_xxBROADCOM_BCM5780:
case MII_MODEL_xxBROADCOM_BCM5706C:
Index: mii/miidevs
===================================================================
RCS file: /home/ncvs/src/sys/dev/mii/miidevs,v
retrieving revision 1.33
diff -u -r1.33 miidevs
--- mii/miidevs 25 Jul 2006 00:14:00 -0000 1.33
+++ mii/miidevs 31 Aug 2006 03:27:57 -0000
@@ -118,6 +118,7 @@
model xxBROADCOM BCM5400 0x0004 Broadcom 1000baseTX PHY
model xxBROADCOM BCM5401 0x0005 BCM5401 10/100/1000baseTX PHY
model xxBROADCOM BCM5411 0x0007 BCM5411 10/100/1000baseTX PHY
+model xxBROADCOM BCM5752 0x0010 BCM5752 10/100/1000baseTX PHY
model xxBROADCOM BCM5701 0x0011 BCM5701 10/100/1000baseTX PHY
model xxBROADCOM BCM5703 0x0016 BCM5703 10/100/1000baseTX PHY
model xxBROADCOM BCM5704 0x0019 BCM5704 10/100/1000baseTX PHY

Attachment: signature.asc
Description: OpenPGP digital signature

Relevant Pages

  • Re: [PATCH] Intel Manageability Engine Interface driver
    ... The patch is large so I'm placing the diff on the web for download ... Why does a new driver have "additional char device for legacy mode"? ... Manageability Engine firmware"? ... The core hardware architecture of Intel Active Management Technology ...
    (Linux-Kernel)
  • Re: ipw2200 and wpa_supplicant
    ... > theres a wpa fix in the latest kernel prepatch ... > and there was also a small patch in the thread on sf.net i posted the ... the new ipw2200 driver. ... Back old ipw2200 firmware files, ...
    (Fedora)
  • Re: 2.6.13-rc6-mm1
    ... firmware driver. ... whitespace and sysfs attributes. ... This patch forces it to be consistent ... trailing white space before being handed to the device driver. ...
    (Linux-Kernel)
  • Re: bge(4) on BCM 5752 A02 panic due to media autoselect
    ... out that without explicitly specifying media type, ... firmware handshake timeout" issue disappear from the said chip. ... Try the attached patch instead and let me know if it works. ... The Linux driver specifically disables ...
    (freebsd-current)
  • Re: linux-next: Tree for June 26
    ... convert tg3 driver to request_firmware ... with this patch applied the tg3 has a NULL pointer dereference ... So using the 'tso5' firmware? ...
    (Linux-Kernel)