Re: recent commits break via 8235 ata

Giorgos Keramidas wrote:
On 2007-03-27 12:27, John Baldwin <jhb@xxxxxxxxxxx> wrote:
If that is the case it's because code was using
rman_get_bus(handle|tag) on a resource that wasn't activated yet which
wouldn't have worked before the nexus changes either. Well, the bus
tag might have been right, but the handle for SYS_RES_MEMORY would
have been wrong.

This is the change which stops snd_hda from working here:

% Date: Wed, 21 Mar 2007 15:39:12 +0000 (UTC)
% Message-Id: <200703211539.l2LFdCQW036704@xxxxxxxxxxxxxxxxxxx>
% From: John Baldwin <jhb@xxxxxxxxxxx>
% Subject: cvs commit: src/sys/dev/acpica acpi.c
% To: src-committers@xxxxxxxxxxx, cvs-src@xxxxxxxxxxx, cvs-all@xxxxxxxxxxx
% Cc:
%
% jhb 2007-03-21 15:39:12 UTC
%
% FreeBSD src repository
%
% Modified files:
% sys/dev/acpica acpi.c
% Log:
% Change acpi's handling of suballocating system resources to be a little
% simpler. It now can just use rman_is_region_manager() during
% acpi_release_resource() to see if the the resource is suballocated from
% a system resource. Also, the driver no longer needs MD knowledge about
% how to setup bus space tags and handles when doing a suballocation, but
% can simply rely on bus_activate_resource() in the parent setting all that
% up.
%
% Revision Changes Path
% 1.233 +39 -55 src/sys/dev/acpica/acpi.c

If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000
(including the sys/modules/padlock/Makefile commit of Sam Leffler, to
fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see
that the snd_hda driver probes my sound card correctly.

Updating after the commit shown above, breaks snd_hda.

I just finished a binsearch and can verify this exact commit causes the
problem for my ATA also. I'll spend some more time debugging it later.

John, can I back out rev 1.233 of acpi.c until you return since it
prevents some machines from booting?

--
Nate
_______________________________________________
freebsd-current@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: recent commits break via 8235 ata
    ... wouldn't have worked before the nexus changes either. ... Well, the bus ... tag might have been right, but the handle for SYS_RES_MEMORY would ...
    (freebsd-current)
  • JNDI datasource in Tomcat 4.0 (no GlobalNamingResources tag)
    ... I've configured Tomcat 4.0.3 to run an application using a JNDI DataSource. ... The server.xml file defines a Context, then a Resource, and then ResourceParameters. ... tomcat-4.0.3 doesn't support the GlobalNamingResources tag. ...
    (comp.lang.java.databases)
  • Embedding XML/HTML Data Inside RESX Files
    ... I would like to place XML and/or HTML tags inside an XML Resource ... However, when putting a CData tag in a Resx file, I receive a parsing ...
    (microsoft.public.dotnet.framework)
  • XML/HTML Within RESX Files?
    ... I would like to place XML and/or HTML tags inside an XML Resource ... However, when putting a CData tag in a Resx file, I receive a parsing ...
    (microsoft.public.dotnet.framework)
  • Re: recent commits break via 8235 ata
    ... Well, the bus ... tag might have been right, but the handle for SYS_RES_MEMORY would ... % acpi_release_resource() to see if the the resource is suballocated from ... Updating after the commit shown above, ...
    (freebsd-current)
Loading