Re: Process for requesting reverting patch?

On Sun, May 13, 2007 at 02:41:58PM -0700, Mark Peek wrote:
On 5/13/07 12:28 PM, Steve Kargl wrote:
On Sun, May 13, 2007 at 09:24:35PM +0200, Dag-Erling Sm??rgrav wrote:
Steve Kargl <sgk@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:
On Sun, May 13, 2007 at 08:23:43PM +0200, Dag-Erling Sm??rgrav wrote:
Steve Kargl <sgk@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:
What is the formal process to get a recent commit to -current
reverted? Do I send email to core?
You start by talking to the person who did the commit. That much should
be obvious.
I would expect a committer, who changes something as important as
the default shell in FreeBSD, to read the freebsd-current mailing
list and the PR database.
I would expect a committer such as yourself to know that there are
better ways to approach this than posting to -current and threatening to
take the matter to core@.


I'm not a committer to the FreeBSD repository. I either
submit patches to fix problems or code for missing library
routines. In this particular case, reverting the tcsh
import is the correct fix (IMHO).

I also didn't threaten anyone or anything. I simply wanted
to know what the procedure is for getting code reverted.


As the owner of the PR and the person that committed the recent tcsh I take
it seriously when someone brings it to my attention. After the PR was
assigned to me, I sent Steve two private emails on 5/7/2007 but with no
response back. Given that it "works for me" on two different systems, I
don't know what I could have done different. Below is the text from the
second one.

I have received zero emails from you (either in my inbox or backup folder
where spam is redirected).

It would have been helpful if you actually sent a followup to the PR.

--
steve
_______________________________________________
freebsd-current@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: Process for requesting reverting patch?
    ... Do I send email to core? ... I would expect a committer such as yourself to know that there are ... I'm not a committer to the FreeBSD repository. ... In this particular case, reverting the tcsh ...
    (freebsd-current)
  • Re: Process for requesting reverting patch?
    ... I would expect a committer such as yourself to know that there are ... In this particular case, reverting the tcsh ... > current32# echo $version ... > current32# which gdb ...
    (freebsd-current)
  • Re: Process for requesting reverting patch?
    ... Steve Kargl writes: ... Do I send email to core? ... to read the freebsd-current mailing ... I would expect a committer such as yourself to know that there are ...
    (freebsd-current)
  • Re: Process for requesting reverting patch?
    ... Do I send email to core? ... How about asking the committer who put it in CVS? ... would seem to be a rather severe problem. ...
    (freebsd-current)
  • Re: Process for requesting reverting patch?
    ... Do I send email to core? ... How about asking the committer who put it in CVS? ... There is no formal process ...
    (freebsd-current)