Re: nfs on zfs panic

On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote:
On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote:
It looks like nvp is NULL at the point where it crashed. Looking at
the zfs code, zfs_vget always returns zero, even if it failed to
find a vnode which matches the given 'inode' number. Try changing
the return statement in zfs_vget from 'return (0)' to 'return
(err)'.

Your analysis is correct, can you commit this?

I tried to commit it but got the 'need Approved by: re' message. Do you
have blanket re approval for this stuff?
_______________________________________________
freebsd-current@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: nfs on zfs panic
    ... the zfs code, zfs_vget always returns zero, even if it failed to ... find a vnode which matches the given 'inode' number. ...
    (freebsd-current)
  • Re: nfs on zfs panic
    ... the zfs code, zfs_vget always returns zero, even if it failed to ... find a vnode which matches the given 'inode' number. ... I tried to commit it but got the 'need Approved by: ...
    (freebsd-current)
  • Re: Freeing vnodes.
    ... I'll merge in your changes and commit that later today. ... diff -u -r1.90 vfs_cache.c ... * Invalidate all entries to a particular vnode. ...
    (freebsd-arch)
  • Re: How to reduce/shrink the size of a VirtualPC disk image (reclaim unused space)
    ... So, should I commit the changes, restart Windows, defrag, zero, shut ... Or create a second installation of Windows on a second image, ...
    (microsoft.public.mac.virtualpc)
  • Re: Freeing vnodes.
    ... On Tue, 29 Mar 2005, Jeff Roberson wrote: ... > I'll look at your patch again soon. ... You should wrap vn_fullpathwith Giant and then commit ... > vnode, or names this vnode is a source for. ...
    (freebsd-arch)