Re: nfs on zfs panic



On Wed, Jun 27, 2007 at 08:37:27AM +0100, Doug Rabson wrote:
On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote:
On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote:
It looks like nvp is NULL at the point where it crashed. Looking at
the zfs code, zfs_vget always returns zero, even if it failed to
find a vnode which matches the given 'inode' number. Try changing
the return statement in zfs_vget from 'return (0)' to 'return
(err)'.

Your analysis is correct, can you commit this?

I tried to commit it but got the 'need Approved by: re' message. Do you
have blanket re approval for this stuff?

Nope. Could you ask re@ for approval? If you don't have time, I'll
handle this later.

--
Pawel Jakub Dawidek http://www.wheel.pl
pjd@xxxxxxxxxxx http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!

Attachment: pgpMRm0sGrg7D.pgp
Description: PGP signature



Relevant Pages

  • Re: nfs on zfs panic
    ... the zfs code, zfs_vget always returns zero, even if it failed to ... find a vnode which matches the given 'inode' number. ...
    (freebsd-current)
  • Re: nfs on zfs panic
    ... the zfs code, zfs_vget always returns zero, even if it failed to ... find a vnode which matches the given 'inode' number. ... I tried to commit it but got the 'need Approved by: ...
    (freebsd-current)
  • [GIT PULL] XFS update for 2.6.24-rc1
    ... commit 7f015072348a14f16d548be557ee58c5c55df0aa ... XFS leaves stray mappings around when it vmaps memory to make it virtually ... SGI-PV: 971902 ... from the underlying inode and opencode copying from the inode fields ...
    (Linux-Kernel)
  • [PATCH take 2 12/28] UBIFS: add the journal
    ... Buds contain file system data - data nodes, inode nodes, etc. ... The idea is that when we commit the journal, ... * nodes in bud eraseblocks become leaf nodes of the file system index tree, ... * This function reserves space in journal head @head. ...
    (Linux-Kernel)
  • [PATCH take 3 13/29] UBIFS: add the journal
    ... Buds contain file system data - data nodes, inode nodes, etc. ... The idea is that when we commit the journal, ... * nodes in bud eraseblocks become leaf nodes of the file system index tree, ... * This function reserves space in journal head @head. ...
    (Linux-Kernel)