Re: ukbd patch advice



As suggested by Andrew Thompson, I have attached the patch
for ukbd.c to show the changes I've made.

Sam.




----- Original Message Follows -----
Hey all,

I have been having a problem with my particular usb
keyboard (0x03 was always being written into the first
element of ukbd_data->keycode basically). I have tracked
it down to a problem somewhere in between the uhci chipset
(same problem with other cuts of uhci chipset), the uhci
and/or ukbd drivers and the keyboard.

A fix to the problem is to reorder members of the struct
ukbd_data. Originally, the members are ordered as
modifiers, reserved and keycode[6] (minus a bunch of
#define's). If I change this order to reserved, modifiers
and keycode[6], my keyboard starts to function as it
should (minus lighting up the LED's but that's another
email all together :)). With this reordering, it stops
other usb keyboards which function with the original code
from working.

I'm wanting submit a patch for this fix (as other people
are experiencing the same problems) but I'm not sure how
to do this. I was thinking along the lines of the usb
quirks function but it appears outside of a function body,
you cannot have the normal if() type statements, only the
preprocessor #ifdef types. To me, having a kernel config
option for a single keyboard on a single driver seems
quite overkill.

Does anyone have any suggestions on what I should do or
can anyone point me to some code that deals with a similar
problem?

On a side note, is anyone able to shed any light into why
they think the above fix works? I am drawing a bit of a
blank to be honest. Is it possible that my fix is only
masking the problem?

If you need any more info or whatever, yell out.

Cheers,

Sam.
_______________________________________________
freebsd-current@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to
"freebsd-current-unsubscribe@xxxxxxxxxxx"

Attachment: ukdb.c.patch
Description: Binary data

_______________________________________________
freebsd-current@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: ukbd patch advice
    ... I have been having a problem with my particular usb keyboard ... problem somewhere in between the uhci chipset (same problem ... I'm wanting submit a patch for this fix (as other people are ...
    (freebsd-current)
  • ukbd patch advice
    ... I have been having a problem with my particular usb keyboard ... problem somewhere in between the uhci chipset (same problem ... I'm wanting submit a patch for this fix (as other people are ...
    (freebsd-current)
  • [PATCH 15/21] KGDB: Fix possibility of missing SysRq-G
    ... [PATCH] Fix possibility of missing SysRq-G ... It is possible that when SysRq-G is triggered via the keyboard that we ...
    (Linux-Kernel)
  • Re: Please Help using Vista and stuck in loop on Error Recovery Sc
    ... I will attempt what you said about entering bios, ... understood how to fix them be able to do anything with it? ... not recommended.Clearing the CMOS battery becomes the easiest option.Turn ... We are doing this to check whether it's Vista,the keyboard or users of the ...
    (microsoft.public.windows.vista.general)
  • Re: [PATCH] Route kbd leds through the generic leds layer (3rd version)
    ... only affect that particular event device, ... My patch just puts a trigger layer between ... keyboard and the loop over devices that keyboard used to do. ... connect the input LEDs to them need an easy and proper way to do so. ...
    (Linux-Kernel)