Re: GSoC2007: cnst-sensors.2007-09-13.patch

Date: Thu, 20 Sep 2007 16:12:13 -0700 (PDT)
From: Doug Barton <dougb@xxxxxxxxxxx>
Sender: owner-freebsd-current@xxxxxxxxxxx

On Wed, 19 Sep 2007, Constantine A. Murenin wrote:

Thanks for testing!

Glad to help. In case it's interesting, I was doing the xorg update with
portmaster last night and I got several "PROCHOT asserted" messages on my
console at different times. I'm assuming that's expected behavior, just
curious if it's something bad, as in when that happens it's time to turn
off the laptop? (I didn't seem them when the happened, they were there
when I got back to check on the compiling.)

Two small comments about the rc.d stuff. First, the empty _flags variable
in defaults/rc.conf should be commented out. Second, the rc.d

How so? I don't see any other empty _flags variables in defaults/rc.conf
being commented out.

Well you missed named_flags. :) But seriously, I didn't realize that
things had gotten quite so out of hand with that ... never mind then.

script needs the shutdown KEYWORD.

Similarly, I don't see why this is needed -- it was not used by the scripts
on which this script was based on

Which scripts? I realize that a distressingly large number of scripts that
start services don't have this keyword, but they should. I'll work on a
patch for that. At the same time, we don't want to add any new scripts
that make the same mistake.

Reading through rc(8) doesn't seem to suggest that this keyword would
actually be applicable here.

As far as I can tell, you're starting a daemon, which means that it should
be cleanly shut down when the system exits.

I've now read rcorder(8) and rc(8). I am very unclear what the
significance of the shutdown keyword is. I thought it was to cause
rc.shutdown to invoke a "stop" at shutdown time, but only 11 of the
scripts in /etc/rc.d include the shutdown keyword. They do include most
of the daemons which look likely to really need to be shut down
(e.g. random, mixer, nfsd, inetd, auditd), but it is missing from a
number of others.

I think 'shutdown' might belong in others, but, if a 'kill -9' does the
same thing as a 'stop' operation for a given daemon, it might be better
to not have 'shutdown' to avoid having a hung daemon delay the shutdown.

The reality is that it looks like it is usually done right and I don't
see any real reason for 'shutdown' in this case.

Feel free to call me a fool. I don't claim to
--
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@xxxxxx Phone: +1 510 486-8634
Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751

Attachment: pgpxSNZcwwqBl.pgp
Description: PGP signature

Relevant Pages

  • Re: 2 Times is a "charm"...HELP! :)
    ... These scripts are not ... then Help and Support. ... >> really needing to check with Dell. ... >> your shutdown issues. ...
    (microsoft.public.windowsxp.general)
  • Re: System V initialization
    ... >> boot when I acquired a new lease on boot this AM. ... >> data at shutdown. ... > I have fixed the problem by changing the order of the scripts in rc6.d. ... I couldn't quite figure out entirely why the ISC code was "inadequate" ...
    (comp.os.linux.setup)
  • Re: Reg Crontab
    ... These two scripts call a servlet to startup & shutdown the application ... The other two scripts also are related to application which actually does ... If you wish to confirm the origin or content of this communication, ...
    (AIX-L)
  • Re: Shutting Down Daemons...
    ... problem seems to happen on a system reboot. ... calling the daemon script with the stop option. ... The K scripts are NOT run from runlevel 5 at shutdown. ...
    (comp.os.linux.misc)
  • Going from multiuser to single-user back to multiuser
    ... mode using shutdown -g0 su. ... A couple of the rc2 startup scripts failed to execute properly: ... dlpid: ... or not you go to single-user mode first. ...
    (comp.unix.sco.misc)
Loading