Re: [PATCH] Re: Linksys PCM200

From: Brooks Davis (brooks_at_one-eyed-alien.net)
Date: 10/22/04

  • Next message: Erik Udo: "Messed up my partition" 
    Date: Fri, 22 Oct 2004 10:53:11 -0700
To: soralx@cydem.org

    On Fri, Oct 22, 2004 at 02:16:54AM -0600, soralx@cydem.org wrote:
    >
    > > Could some people with dc(4) devices please test the following patch?
    > > It compiles for me and is trivial, but a quick test is probalby in order
    > > before I commit it.
    >
    > It's rather necessary to test it well, because I didn't actually remove
    > the card's case to see the chip; I relied on my own tests and info from
    > the INet, thus some problems may appear if Linksys modified the chipset
    >
    > Linksys PCM200 is the only 32-bit PCMCIA NIC available in Compusmart -
    > I'm sure that soon someone will buy the card, find the patch, and test
    > it. It's better to wait for feedback before committing the patch.

    If you have done any testing, that should be sufficent. After all, the
    hardware didn't work before, right? It did work before that's another
    issue, but if not, all that matters is that we don't break any other
    cards.

    > > This differs from soralx's patch in that it adds
    > > comments on the 0xab08 collisions and shortens the description string to
    > > something that will fit in one line on the console.
    >
    > I suggest that you change the description to:
    > "Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek Centaur-C)"
    >
    > Card's versions differ between each other significantly. Also, there will
    > be no easy way to find out card's chipset if it won't be stated in the
    > description.
    > The string will fit on console even better:
    >
    > dc0: <Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek Centaur-C)> port
    > 0x1000-0x10ff mem 0x88002000-0x880023ff irq 9 at device 0.0 on cardbus1

    I disagree. If you need that level fo detail, you should use pciconf
    -lv.

    -- Brooks 

    -- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

  • Next message: Erik Udo: "Messed up my partition"

    Relevant Pages

    • [PATCH] Re: Linksys PCM200
      ... > before I commit it. ... > something that will fit in one line on the console. ... The string will fit on console even better: ...
      (freebsd-hackers)
    • Re: [GIT PATCH] another tranche of SCSI updates for 2.6.26
      ... commit 064922a805ec7aadfafdd27aa6b4908d737c3c1d ... This patch adds more const keywords where appropriate. ... fix SLUB WARN_ON ... KVM: SVM: remove now obsolete FIXME comment ...
      (Linux-Kernel)
    • Re: Linux 2.6.21-rc6
      ... [PATCH] ... Change code ordering in disk.c ... The changes here only affect the built-in swsusp. ... the remaining test is to try reverting this commit from -rc6. ...
      (Linux-Kernel)
    • Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl
      ... MAINTAINERS information, we have 3 options: ... There are things git can help, and other things git does not ... Linus already gave a script to grep *-by: lines from commit ... integration to git-based patch flow. ...
      (Linux-Kernel)
    • Re: Linux 2.6.21-rc6
      ... [PATCH] ... Change code ordering in disk.c ... The changes here only affect the built-in swsusp. ... the remaining test is to try reverting this commit from -rc6. ...
      (Linux-Kernel)