Re: Creating Compressed Loop FS from stdin
From: Maxim Sobolev (sobomax_at_portaone.com)
Date: 12/30/04
- Previous message: Maxim Sobolev: "Re: Creating Compressed Loop FS from stdin"
- In reply to: Peter Pentchev: "Re: Creating Compressed Loop FS from stdin"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 30 Dec 2004 17:08:10 +0200 To: Peter Pentchev <roam@ringlet.net>
Never mind - people are inheretedly error prone creatures. ;-)
In your case shell has been passing file descriptor of the open file,
not pipe, so that seeking has been working properly.
Anyway, I think that your patch is useful, since it should allow using
disk devices.
-Maxim
Peter Pentchev wrote:
> On Thu, Dec 30, 2004 at 04:55:43PM +0200, Peter Pentchev wrote:
>
>>On Thu, Dec 30, 2004 at 04:20:16PM +0200, Maxim Sobolev wrote:
>>
>>>You don't check return code of the second lseek - I bet it fails. This
>>>probably leads to creation of seemingly valid loop fs (i.e. with valid
>>>header), but filled with zeroes or some random junk.
>>
>>I said I'd tested it before posting it the first time. It works.
>>It creates a valid loop fs, containing exactly the files that are in
>>the input ISO image.
>
>
> Errr. Oops.
>
> Sorry everyone - the patch does not really work. I keep testing it with
> a *file* passed on mkuzip's stdin, all the while feeling surprised that
> lseek() works on the pipe... when there is no pipe at all :(
>
> I just tested it with a real pipe, and of course, it failed. Again,
> sorry for wasting your time; I guess it'd be best if I tucked in for
> the holidays now :(
>
> G'luck,
> Peter
>
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
- Previous message: Maxim Sobolev: "Re: Creating Compressed Loop FS from stdin"
- In reply to: Peter Pentchev: "Re: Creating Compressed Loop FS from stdin"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|