Latest patch for PPP
- From: Frederic Praca <frederic.praca@xxxxxxxxxxxxxx>
- Date: Fri, 25 Aug 2006 18:46:13 +0200
Hello,
in the latest security advisory for PPP, the patch deals with conditions
in a for loop. The correct line is :
for (rlen=0; len >= 2 && p[1] >= 2 && len >= p[1]; len-=p[1], p+=p[1]) {
Couldn't the condition be simpler like :
for (rlen=0; p[1] >= 2 && len >= p[1]; len-=p[1], p+=p[1]){
Or is there a hack I didn't understand ?
In this case, if p[1] is greater or equal than 2, if we ensure that len
= p[1], we don't have to test that it's greater or equal than 2, isn't
it ?
Fred
_______________________________________________
freebsd-hackers@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@xxxxxxxxxxx"
- Follow-Ups:
- Re: Latest patch for PPP
- From: Roman Kurakin
- Re: Latest patch for PPP
- Prev by Date: Re: [PATCH] adding two new options to 'cp'
- Next by Date: momentary system "pauses" when switching VTYs
- Previous by thread: Re: How to change kernel version?
- Next by thread: Re: Latest patch for PPP
- Index(es):