Re: src.conf(5) seems to affect ports build

Hi Ruslan,

On Fri, Oct 20, 2006 at 11:13:32PM +0400, Ruslan Ermilov wrote:
On Fri, Oct 20, 2006 at 05:08:48PM +0200, Jeremie Le Hen wrote:
Hi,

src.conf(5) manual page states:

% The src.conf file contains settings that will apply to every build
% involving the FreeBSD source tree; see build(7).
% ...
% The only purpose of src.conf is to control the compilation of the FreeBSD
% sources, which are usually found in /usr/src.

However, share/mk/bsd.port.mk includes <bsd.own.mk> which in turn includes
/etc/src.conf. Therefore if I have some WITH_/WITHOUT_ knob in it
which affects CFLAGS, they will be taken into account even for port builds.

Is it the expected behaviour ? Maybe WITH(OUT)_ should simply avoid
modifying CFLAGS (though I think this might become useful in the near
future).

See if the attached patch helps. If it does, I'll commit. I've
never heard back on this patch after I sent it to obrien@.

This patch works correctly. Would you explain me why assigning
/dev/null to _SRCCONF don't work in the current version of bsd.port.mk ?

Also, your patch avoids performing the WITH(OUT)_* stuff for ports in
order to prevent from polluting the namespace. If there is to be
some WITH(OUT)_* knobs which leads to CFLAGS modification in the future
(I'm thinking about ProPolice with the upcoming GCC 4.1), wouldn't it
be worth benefiting this framework for ports ?

Thank you.
Regards,
--
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
_______________________________________________
freebsd-hackers@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: problems with KB951746
    ... Blocking legitimate IP addresses responding on ports the ... using the net will cause the firewall to block IPs more rapidly. ... I doubt the patch, or SBS, is the problem here. ... tried different forwarders, different DNS servers, and root hints only. ...
    (microsoft.public.windows.server.sbs)
  • Re: problems with KB951746
    ... Blocking legitimate IP addresses responding on ports the firewall doesn't expect will cause problems. ... What I suspect is happening is that the patch is doing what it is supposed to do. ... It is also possible, but less likely, that your ISP's DNS servers are misconfigured and are unable to reply on odd source ports. ...
    (microsoft.public.windows.server.sbs)
  • Re: Patch available for shared em interrupts (Re: em, bge, network problems survey.)
    ... Note that this patch will not help you if you are not using the em ... shared irq that can be studied separately. ... <ACPI PCI bus> on pcib0 ... 2 ports with 2 removable, ...
    (freebsd-stable)
  • Re: [patch 0/8] xtensa: s6000 & s6105
    ... here is the core series of our s6000 port. ... First comes the nommu patch. ... everything that separates the S6000 from existing ports, ...
    (Linux-Kernel)
  • Re: [PATCH] for acpi S1 power cycle resume problems
    ... > I was told that if I had a patch to submit for a baseline change that ... > have 3 RWC bits, ... whoever did that RWC patch for UHCI ports certainly should ...
    (Linux-Kernel)