Re: Init.c, making it chroot
- From: "M. Warner Losh" <imp@xxxxxxxxxx>
- Date: Sat, 06 Jan 2007 11:33:48 -0700 (MST)
this patch looks good, however, one nit:
In message: <200701052106.l05L60a6042599@xxxxxxxxxxxxxxxxx>
Oliver Fromme <olli@xxxxxxxxxxxxxxxxx> writes:
: + if (stat("/dev", &stst) != 0)
: + warning("Can't stat /dev: %m");
: + else {
: + if (stst.st_dev == root_devno)
: + devfs++;
: + }
is more succinctly expressed as:
+ if (stat("/dev", &stst) != 0)
+ warning("Can't stat /dev: %m");
+ else if (stst.st_dev == root_devno)
+ devfs++;
Also, kenv(KENV_GET, ... is used a lot. Maybe it makes sense to have
a simple kenvget call. Would make a few lines a little shorter if
nothing else.
Otherwise, I think this is a great patch. I don't see other problems
with it.
Warner
_______________________________________________
freebsd-hackers@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@xxxxxxxxxxx"
- Follow-Ups:
- Re: Init.c, making it chroot
- From: Oliver Fromme
- Re: Init.c, making it chroot
- References:
- Re: Init.c, making it chroot
- From: John Baldwin
- Re: Init.c, making it chroot
- From: Oliver Fromme
- Re: Init.c, making it chroot
- Prev by Date: Re: kern/89528: [jail] impossible to kill a jail
- Next by Date: Re: Init.c, making it chroot
- Previous by thread: Re: Init.c, making it chroot
- Next by thread: Re: Init.c, making it chroot
- Index(es):
Relevant Pages
|
|
