Re: KSE was Re: open/close/ioctl api change?



Danny Braniss wrote:
Danny Braniss wrote:
actually it's the struct thread *tp where my problems are,
this code works fine under 6.2, and did work till some days ago under current.

static int
iscsi_open(struct cdev *dev, int flags, int otype, struct thread *td)
{
...
debug(3, "td->td_proc=%p", td->td_proc);
debug(3, "td->td_proc->p_pid=%d pid=%d",
td->td_proc->p_pid, curproc->p_pid);
...

the first debug prints out td->td_proc=0 and the next one panics.
found the problem, 'option KSE' which is defined now in DEFAULTS,
and i'm compiling a module! which does not include DEFAULTS!

even so it shouldnt' happen..

why? I'm compiling outside the source tree.
I agree that it shouldn't, specially, since it took me a long
time to find the problem :-), but I can't see how config options
can be exported. Unless, the make file is made aware of the KERNCONF file.

there should be no place in the source at any time where a thread that is not on the free list could have a td_proc of NULL.
it doesn't matter about where a module came from etc.. the fact that
it happened is a bug somewhere.


danny


_______________________________________________
freebsd-hackers@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: Explain this
    ... At least in C and C++, the fact that we're assigning a char to x ... and C++ in a different way: in C, a character literal has type int, ... compiling it as C++ would assign to the global. ... but a language that was considerably different ...
    (comp.lang.cpp)
  • Re: Linking Problem
    ... the actual performance cost for CPU-bound code is ... With MF COBOL you have the option of compiling to INT, ...
    (comp.lang.cobol)
  • Re: jail extensions
    ... and disable module compiling when module don`t marked jail ... for each jail, but in order to make this continue to work in the existing system, they still need to ... static int yy; ... struct a { ...
    (freebsd-arch)
  • Re: KSE was Re: open/close/ioctl api change?
    ... iscsi_open(struct cdev *dev, int flags, int otype, struct thread *td) ... found the problem, 'option KSE' which is defined now in DEFAULTS, ... I'm compiling outside the source tree. ...
    (freebsd-current)
  • Re: KSE was Re: open/close/ioctl api change?
    ... iscsi_open(struct cdev *dev, int flags, int otype, struct thread *td) ... found the problem, 'option KSE' which is defined now in DEFAULTS, ... I'm compiling outside the source tree. ...
    (freebsd-hackers)