Re: config(8) patch for review for src dir handling
- From: Ed Maste <emaste@xxxxxxxxxxx>
- Date: Wed, 26 Dec 2007 21:54:19 -0500
On Sun, Dec 23, 2007 at 10:40:39AM +0100, Dag-Erling Sm??rgrav wrote:
Ed Maste <emaste@xxxxxxxxxxx> writes:
Right now config(8) calls realpath("../..", ... to find the src path
to write into the kernel Makefile. I want to change this to use $PWD
with the last two path components removed, assuming it's the same dir
as ../.. .
I'm worried that your patch assumes that $PWD is present and correct,
for which there is no guarantee. What happens if you use getcwd()
instead of getenv("PWD")?
The patch assumes neither; it checks for $PWD and verifies that the dir
obtained by removing the last two components is the same as that
provided by realpath("../.." . If $PWD is not set, or the path based on
it is not correct, it falls back to the current behaviour -- the path
returned by realpath("../.." .
Getcwd doesn't give the desired behaviour since, like realpath, it
returns the physical directory.
-Ed
_______________________________________________
freebsd-hackers@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@xxxxxxxxxxx"
- References:
- config(8) patch for review for src dir handling
- From: Ed Maste
- Re: config(8) patch for review for src dir handling
- From: Dag-Erling Smørgrav
- config(8) patch for review for src dir handling
- Prev by Date: Re: quest for USB only mouse operation
- Next by Date: Re: Synaptics
- Previous by thread: Re: config(8) patch for review for src dir handling
- Next by thread: critical floating point incompatibility
- Index(es):
Relevant Pages
|
|
