Re: Fwd: 5.2-RC + ipfw

From: Maxim Konovalov (maxim_at_macomnet.ru)
Date: 12/14/03

  • Next message: Charles Swiger: "Re: Controlling ports used by natd"
    Date: Sun, 14 Dec 2003 14:35:13 +0300 (MSK)
    To: Nate Grey <NateBSD@yahoo.it>
    
    

    On Sun, 14 Dec 2003, 12:23-0000, Nate Grey wrote:

    > On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
    > > Please try an enclosed patch or put a whitespace right after the '('
    > > before '\'.
    > >
    > > Index: ipfw2.c
    > > ===================================================================
    > > RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
    > > retrieving revision 1.42
    > > diff -u -r1.42 ipfw2.c
    > > --- ipfw2.c 31 Oct 2003 18:31:55 -0000 1.42
    > > +++ ipfw2.c 13 Dec 2003 18:42:18 -0000
    > > @@ -2901,15 +2901,14 @@
    > > goto done;
    > >
    > > #define OR_START(target) \
    > > - if (ac && (*av[0] == '(' || *av[0] == '{')) { \
    > > + if (ac && ( \
    > > + !strncmp(*av, "(", strlen(*av)) || \
    > > + !strncmp(*av, "{", strlen(*av)) )) { \
    > > if (open_par) \
    > > errx(EX_USAGE, "nested \"(\" not allowed\n"); \
    > > prev = NULL; \
    > > open_par = 1; \
    > > - if ( (av[0])[1] == '\0') { \
    > > - ac--; av++; \
    > > - } else \
    > > - (*av)++; \
    > > + ac--; av++; \
    > > } \
    > > target: \
    > >
    > > %%%
    >
    > Problem solved just adding a whitespace. Should I apply the patch anyway?

    Please do if you can. Thanks.

    -- 
    Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org
    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
    

  • Next message: Charles Swiger: "Re: Controlling ports used by natd"

    Relevant Pages

    • Re: Best Practice re: patching multiple Sun Servers connected to a Hitachi SAN
      ... > I am a system administrator for several Sun Servers and encountered several ... > of patching and security hardening Sun Servers. ... I decided to only patch the development servers. ... > breaks parts of Veritas. ...
      (comp.unix.solaris)
    • Re: dictionary comparison
      ... > I'm trying to compare sun patch levels on a server to those of what ... For those that aren't familiar with sun patch ... I want to show what server x has ... > versus what sun recommends, and if the patch exists, but the revision ...
      (comp.lang.python)
    • Re: dictionary comparison
      ... >I'm trying to compare sun patch levels on a server to those of what sun ... For those that aren't familiar with sun patch ... I want to show what server x has ... >versus what sun recommends, and if the patch exists, but the revision ...
      (comp.lang.python)
    • Re: Bad TRAP occurred in module "ufs" due to a NULL pointer dereference
      ... Obviously Sun noticed our problem now and there is a Sun Alert ... > Solaris 8 actual recommended patch cluster installed. ... > to an NFS mounted partition of the server with command mv. ...
      (comp.unix.solaris)
    • [PATCH] CodingStyle adherence part 1 - if else cleanup part 1
      ... (whitespace cleanup)' thread, I've started doing whitespace cleanups to ... make the kernel adhere closer to Documentation/CodingStyle. ... I started with the if/else cleanups. ... Judging by if statements only we can see that this patch does aproximately ...
      (Linux-Kernel)