Re: RFC: if_clone overhaul

From: Brooks Davis (brooks_at_one-eyed-alien.net)
Date: 04/22/04

  • Next message: Jay Hall: "Assigning a specific IP address and Interface with MPD"
    Date: Wed, 21 Apr 2004 22:39:18 -0700
    To: net@freebsd.org
    
    
    

    On Tue, Apr 20, 2004 at 09:24:53PM -0700, Brooks Davis wrote:
    > Please test/review the following patch to the network interface cloneing
    > code. This code is a major overhaul of the cloning infrastructure.

    Repeat after me, always test your "trivial" last minute changes. You
    need to apply the following patch after applying the previous patch if
    you want the code to compile.

    -- Brooks

    Change 51546 by brooks@brooks_minya on 2004/04/21 22:29:18

            Unreorder struct if_clone so initalizer works. Should probably
            switch to C99 sparc initalizers..

    Affected files ...

    .. //depot/user/brooks/xname/sys/net/if_clone.h#11 edit

    Differences ...

    ==== //depot/user/brooks/xname/sys/net/if_clone.h#11 (text+ko) ====

    @@ -61,14 +61,15 @@
                                             /* via ifc_(alloc|free)_unit(). */
             int ifc_bmlen; /* (c) Bitmap length. */
             void *ifc_data; /* (*) Data for ifc_* functions. */
    - long ifc_refcnt; /* (i) Refrence count. */
    - struct mtx ifc_mtx; /* Muted to protect members. */
     
             /* (c) Driver specific cloning functions. Called with no locks held. */
             void (*ifc_attach)(struct if_clone *);
             int (*ifc_match)(struct if_clone *, const char *);
             int (*ifc_create)(struct if_clone *, char *, size_t);
             int (*ifc_destroy)(struct if_clone *, struct ifnet *);
    +
    + long ifc_refcnt; /* (i) Refrence count. */
    + struct mtx ifc_mtx; /* Muted to protect members. */
     };
     
     void if_clone_init(void);

    -- 
    Any statement of the form "X is the one, true Y" is FALSE.
    PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
    
    



  • Next message: Jay Hall: "Assigning a specific IP address and Interface with MPD"

    Relevant Pages

    • Re: 2.6.0-test5 vs. Japanese keyboards [3]
      ... "Andries Brouwer" wrote: ... Do not repeat the complaining because complaining ... > this is the correct patch, sooner or later somebody will look at it. ...
      (Linux-Kernel)
    • Re: 2.6.0-test5 vs. Japanese keyboards [1]
      ... Do not repeat the complaining because complaining ... > this is the correct patch, sooner or later somebody will look at it. ... If Dr. Brouwer or anyone else has ...
      (Linux-Kernel)
    • Re: 2.6.0-test5 vs. Japanese keyboards [2]
      ... Do not repeat the complaining because complaining ... > this is the correct patch, sooner or later somebody will look at it. ... 2.6.0-test4, Japanese USB keyboards, keycodes 181 and 183 ...
      (Linux-Kernel)
    • Re: kaleidoscope quilt
      ... The more contrast between the background and the pattern the better the kaleidoscope stands out. ... The size of the repeat doesn't matter so much as the variety in each repeat. ... Patch Stacked Posey pattern. ...
      (rec.crafts.textiles.quilting)
    • Re: Bug in latest rev kern_acct.c: panic: Trying sleep, but thread marked as sleeping prohibited
      ... Probably the easiest fix is to stick acctwatch() in its ... could you try to repeat your problem with my patch? ... in the logs and no panics. ...
      (freebsd-current)