Re: shutdown node VS disconnect all hooks

From: Gleb Smirnoff (glebius_at_cell.sick.ru)
Date: 05/28/04

  • Next message: Gleb Smirnoff: "Re: shutdown node VS disconnect all hooks" 
    Date: Fri, 28 May 2004 14:09:14 +0400
To: Julian Elischer <julian@elischer.org>

    On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote:
    J> > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that
    J> > JE>> case could you please convert the initialisation of the typestructs
    J> > JE>> to use C99 sparse initialisation? In that case future changes will be a good
    J> > JE>> deal easier.
    J> > JE>
    J> > JE>actually I don't know if you do need to edit the nodes
    J> > JE>types.. At one time it was true that unassigned elements on
    J> > JE>the end will be NULL.
    J> >
    J> > Sure they will, but this will confuse the next one who is adding
    J> > a new operation. I was just thinking: 'In the case that Gleb has nothing
    J> > else to do he could as well just take the chance...' :-)
    J>
    J> He seems to have taken the bait
    J> (heh heh)
    J>
    J> It'd be best to make the change to sparse initialisers a separate patch
    J> that I cold commit separatly,
    J> so reduce teh size of the functionality change patch.
    J>
    J> (or harti could commit it.., or ruslan)

    Agreed. I make a series of patches then :)

    Here is the first one - convert all ng_type initializers to C99 sparse type.

    AFAIK, we also have two netgraph ports. Adding of preshutdown method will break
    them. I'll fix ng_netflow port, and notify maintainer of ng_daphne. 

    -- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Gleb Smirnoff: "Re: shutdown node VS disconnect all hooks"