Re: New preview patch for ipfw to pfil_hooks conversion

From: Andre Oppermann (andre_at_freebsd.org)
Date: 06/22/04

  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion" 
    Date: Tue, 22 Jun 2004 13:38:59 +0200
To: Maxim Konovalov <maxim@macomnet.ru>

    Maxim Konovalov wrote:
    >
    > Hi Andre,
    >
    > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
    >
    > > Here is the next preview patch for the ipfw to pfil_hooks conversion:
    > >
    > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
    > >
    > > This patch significantly cleans up ip_input.c and ip_output.c.
    >
    > Is it possible to split that ~100KB patch in a logic chunks? One for
    > phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to
    > review and commit them later.

    Of course it will be split up. I haven't done this because this is
    only a preview patch of work in progress.

    > > Consider this a FYI. It is very much a WIP at the moment. I want
    > > to get this into the tree in before 5.3 code freeze.
    >
    > In fact, our real world tests shown the current -CURRENT comparing to
    > RELENG_5_2 is in a very bad shape. Is it really worth to commit that
    > mostly cleanup code before say 6-CURRENT with a chance to
    > destabilizate -CURRENT a bit more?

    This will not destabilize -CURRENT anymore. Any errors in the code
    are seen immediatly. 

    -- 
Andre
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion"

    Relevant Pages

    • Re: New preview patch for ipfw to pfil_hooks conversion
      ... > review and commit them later. ... only a preview patch of work in progress. ... > mostly cleanup code before say 6-CURRENT with a chance to ... > destabilizate -CURRENT a bit more? ...
      (freebsd-current)
    • Re: [GIT PATCH] another tranche of SCSI updates for 2.6.26
      ... commit 064922a805ec7aadfafdd27aa6b4908d737c3c1d ... This patch adds more const keywords where appropriate. ... fix SLUB WARN_ON ... KVM: SVM: remove now obsolete FIXME comment ...
      (Linux-Kernel)
    • Re: Linux 2.6.21-rc6
      ... [PATCH] ... Change code ordering in disk.c ... The changes here only affect the built-in swsusp. ... the remaining test is to try reverting this commit from -rc6. ...
      (Linux-Kernel)
    • Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl
      ... MAINTAINERS information, we have 3 options: ... There are things git can help, and other things git does not ... Linus already gave a script to grep *-by: lines from commit ... integration to git-based patch flow. ...
      (Linux-Kernel)
    • Re: Linux 2.6.21-rc6
      ... [PATCH] ... Change code ordering in disk.c ... The changes here only affect the built-in swsusp. ... the remaining test is to try reverting this commit from -rc6. ...
      (Linux-Kernel)