Re: New preview patch for ipfw to pfil_hooks conversion

From: Andre Oppermann (andre_at_freebsd.org)
Date: 06/22/04

  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion" 
    Date: Tue, 22 Jun 2004 13:38:59 +0200
To: Maxim Konovalov <maxim@macomnet.ru>

    Maxim Konovalov wrote:
    >
    > Hi Andre,
    >
    > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
    >
    > > Here is the next preview patch for the ipfw to pfil_hooks conversion:
    > >
    > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
    > >
    > > This patch significantly cleans up ip_input.c and ip_output.c.
    >
    > Is it possible to split that ~100KB patch in a logic chunks? One for
    > phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to
    > review and commit them later.

    Of course it will be split up. I haven't done this because this is
    only a preview patch of work in progress.

    > > Consider this a FYI. It is very much a WIP at the moment. I want
    > > to get this into the tree in before 5.3 code freeze.
    >
    > In fact, our real world tests shown the current -CURRENT comparing to
    > RELENG_5_2 is in a very bad shape. Is it really worth to commit that
    > mostly cleanup code before say 6-CURRENT with a chance to
    > destabilizate -CURRENT a bit more?

    This will not destabilize -CURRENT anymore. Any errors in the code
    are seen immediatly. 

    -- 
Andre
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion"

    Relevant Pages

    • Re: New preview patch for ipfw to pfil_hooks conversion
      ... > review and commit them later. ... only a preview patch of work in progress. ... > mostly cleanup code before say 6-CURRENT with a chance to ... > destabilizate -CURRENT a bit more? ...
      (freebsd-current)
    • Re: NEWBUS states
      ... :>: I think the right fix here is to maintain in sync devinfo.h and bus.h ... Obviously that is not a finished patch, ... I'm specifically suggesting that we only MFC ... that would mean to not commit a patch and make impossible a future ...
      (freebsd-arch)
    • Re: [GIT PATCH] another tranche of SCSI updates for 2.6.26
      ... commit 064922a805ec7aadfafdd27aa6b4908d737c3c1d ... This patch adds more const keywords where appropriate. ... fix SLUB WARN_ON ... KVM: SVM: remove now obsolete FIXME comment ...
      (Linux-Kernel)
    • Re: Impact: (was Re: [PATCH] update rwlock initialization for nat_table)
      ... The commit e099a173573ce1ba171092aee7bb3c72ea686e59 ... As Andrew mentioned this is a bug (albeit a "nano-bug" as you ... hard to describe the practical impact of a patch in a single line, ... Try it if you dont believe me;-) In ...
      (Linux-Kernel)
    • Re: [Bug #14141] order 2 page allocation failures in iwlagn
      ... *only* printed when the RX buffers are really low. ... that patch triggers them in the extreme swap situation. ... but could not find an obvious candidate within the page allocator itself which ... this driver and I think we have the problem commit there. ...
      (Linux-Kernel)