Re: New preview patch for ipfw to pfil_hooks conversion

From: Andre Oppermann (andre_at_freebsd.org)
Date: 06/22/04

  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion" 
    Date: Tue, 22 Jun 2004 13:45:40 +0200
To: Maxim Konovalov <maxim@macomnet.ru>

    Maxim Konovalov wrote:
    >
    > On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote:
    >
    > > On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote:
    > > ...
    > > > > Consider this a FYI. It is very much a WIP at the moment. I want
    > > > > to get this into the tree in before 5.3 code freeze.
    > > >
    > > > In fact, our real world tests shown the current -CURRENT comparing to
    > > > RELENG_5_2 is in a very bad shape. Is it really worth to commit that
    > > > mostly cleanup code before say 6-CURRENT with a chance to
    > >
    > > of course it is! i also do not follow the reasoning -- given that it is
    > > cleaning up code, it is only welcome at any stage except perhaps
    > > in code freeze.
    >
    > My concern is bugs. Especially in cleanup code, especially in
    > ip_pcbopt and ip_reass.

    I do not modify ip_pcbopt in any way. All the IP Options stuff is simply
    a 1:1 code move to get them all in one single place.

    For ip_reass() I've taken a very conservative approach and just moved
    the external code into the function itself. In terms of coding style
    it looks a bit ugly but is a pure 1:1 adaption of the existing code.
    Thus I'm sure that I haven't changed the behaviour of the ip reassembly
    code in any way (except one). I agree that a rewrite of ip_reass() is
    a very delicate thing because of possible bugs, but that is not what I
    have done. 

    -- 
Andre
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Andre Oppermann: "Re: New preview patch for ipfw to pfil_hooks conversion"

    Relevant Pages

    • Re: New preview patch for ipfw to pfil_hooks conversion
      ... Maxim Konovalov wrote: ... >> cleaning up code, it is only welcome at any stage except perhaps ... >> in code freeze. ... > My concern is bugs. ...
      (freebsd-current)
    • HEADS UP! 6.0 Schedule, 6.0-CURRENT Snapshot
      ... The long anticipated and much feared 6.0 code freeze is about to begin! ... From June 10 until the release, the number one priority is fixing bugs. ... the plan is for 6.0 to be a modest replacement for 5.x. ... support into at least 2007 (going by their normal formula), ...
      (freebsd-current)
    • HEADS UP! 6.0 Schedule, 6.0-CURRENT Snapshot
      ... The long anticipated and much feared 6.0 code freeze is about to begin! ... From June 10 until the release, the number one priority is fixing bugs. ... the plan is for 6.0 to be a modest replacement for 5.x. ... support into at least 2007 (going by their normal formula), ...
      (freebsd-hackers)
    • Re: Cutting Board that can Take The HEAT?
      ... it is hard to clean poluethylene cuting boards. ... Maybe the bugs hide out in the knife cuts in wood too, ... Note that I did explain my point of view would be cleaning up the rig ...
      (rec.woodworking)
    • Re: HEADS UP! 6.0 Schedule, 6.0-CURRENT Snapshot
      ... > The long anticipated and much feared 6.0 code freeze is about to begin! ... > From June 10 until the release, the number one priority is fixing bugs. ... A stroll through the mailing lists and PR ...
      (freebsd-current)