Re: New preview patch for ipfw to pfil_hooks conversion

From: Maxim Konovalov (maxim_at_macomnet.ru)
Date: 06/22/04

  • Next message: Yohan: "Re: PPPoE RESOLVED" 
    Date: Tue, 22 Jun 2004 16:29:01 +0400 (MSD)
To: Andre Oppermann <andre@freebsd.org>

    On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote:

    > Maxim Konovalov wrote:
    > >
    > > Hi Andre,
    > >
    > > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
    > >
    > > > Here is the next preview patch for the ipfw to pfil_hooks conversion:
    > > >
    > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
    > > >
    > > > This patch significantly cleans up ip_input.c and ip_output.c.
    > >
    > > Is it possible to split that ~100KB patch in a logic chunks? One for
    > > phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to
    > > review and commit them later.
    >
    > Of course it will be split up. I haven't done this because this is
    > only a preview patch of work in progress.

    Please HEADSUP us before commit or drop me a note, I am willing to
    review reass/ip options code as I spent a lot of hours parsing it.

    As a side note, what is "#define MAX_IPOPTLEN 40" in
    ip_options.h for? There is one in ip_var.h. 

    -- 
Maxim Konovalov
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Yohan: "Re: PPPoE RESOLVED"

    Relevant Pages

    • Re: New preview patch for ipfw to pfil_hooks conversion
      ... On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote: ... Please HEADSUP us before commit or drop me a note, ... review reass/ip options code as I spent a lot of hours parsing it. ... Maxim Konovalov ...
      (freebsd-current)
    • Re: cvs commit: www/en/projects/ideas index.sgml
      ... My impression is, that we lack some committers which not only have time to review the submissions, but also have the necessary domain specific knowledge at the same time. ... I'm not able to review the code, but I wanted to give it a try on my system and then send a mail to arch to get some technical reasons why to not commit commit it. ... And some ideas are expressed in a way which make them sound like it's "common knowledge to people which work in this field" (ATM I refer to the NFS lockd in kernel implementation idea). ... Given that we can't get the user space code to work and don't have an owner for it, I think moving it into the kernel would be a disaster. ...
      (freebsd-hackers)
    • Re: cvs commit: www/en/projects/ideas index.sgml
      ... My impression is, that we lack some committers which not only have time to review the submissions, but also have the necessary domain specific knowledge at the same time. ... I'm not able to review the code, but I wanted to give it a try on my system and then send a mail to arch to get some technical reasons why to not commit commit it. ... security). ... false impression that this is a "todo" list. ...
      (freebsd-hackers)
    • Re: Problem with uipc_mbuf.c
      ... Andre Oppermann wrote: ... Fix a logic error introduced with mandatory mbuf cluster ... commit fixed it in some way. ... then we will have an mbuf leak unless we change ...
      (freebsd-net)
    • Re: Problem with closing tcp session between cisco and freebsd
      ... On Tue, 16 Mar 2004, Andre Oppermann wrote: ... > March 2 the commit of the TCP segment reassembly queue limiter has ... > So no obvious suspect. ... Before digging deep into the code its better ...
      (freebsd-net)