Re: kern/45733: file descriptor flags and socket flags out of sync

From: Bruce M Simpson (bms_at_spc.org)
Date: 06/23/04

  • Next message: Peter Wemm: "Re: src/sbin/routed doesn't store code in src/contrib/" 
    Date: Wed, 23 Jun 2004 02:23:54 +0100
To: Robert Watson <rwatson@freebsd.org>

    On Tue, Jun 22, 2004 at 09:04:35PM -0400, Robert Watson wrote:
    > Since you're looking at the propagation of head so_state to new socket
    > so_state, you might want to look at the similar statement in sonewconn(),
    > which copies so_state from head to the new socket, and adds the SS_NOFDREF
    > flag. Should we only be propagating SS_NBIO here as well?

    Verdict: not proven. SS_NOFDREF implies that no file descriptor references
    the socket, so similar inconsistencies between the FD and the SO wouldn't
    apply here.

    The state of the socket 'head' is likely to be consistent with regards to
    the other SS_* flags as 'head' is a listening socket, and such sockets
    don't generally appear to be used for straight I/O from userland (in
    the PF_INET, SOCK_STREAM case, listening sockets are effectively just
    endpoints for servicing SYNs - all userland I/O happens through connected
    sockets derived from such listening sockets).

    It is also possible that the fix we applied for the accept1() case is
    incomplete; it's also possible that we should in fact have applied it
    here.

    If you could remind me of the URL of that dotfile you graphed with the
    socket layer call graph, that would be most useful. ;-)

    There are however a bunch of bits which probably shouldn't be applied
    to the new socket, but as above, it looks like these shouldn't be
    in effect for the listening socket.

    Regards,
    BMS
    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"

  • Next message: Peter Wemm: "Re: src/sbin/routed doesn't store code in src/contrib/"

    Relevant Pages

    • Re: kern/45733: file descriptor flags and socket flags out of sync
      ... > In the end this is what it boils down to. ... Since you're looking at the propagation of head so_state to new socket ... which copies so_state from head to the new socket, ...
      (freebsd-net)
    • Re: Freeze.Panes revisited
      ... > They're already talking 'bout it down in the head office. ... > between the DSL modem and the telephone socket shall not be more than ... > SEVEN FEET, if I want a decent signal. ... And, of course, I've gotta get it up and working. ...
      (sci.med.dentistry)
    • Re: incorrect errno/perror with IO::socket->new
      ... b> No I am expecting that Socket->newis making system calls and if ... b> I am left only with an undef $socket. ... b> clean up then saving it and restoring it after all clean up system ... your head and not the module. ...
      (comp.lang.perl.misc)
    • Re: Head bolt sheared -- how to get out
      ... >> I finally got a socket to fit the head bolts on my 1990 2.3 Mustang but ... >I would have used a regular socket on my impact wrench, ... >You can normally take your head to a machine shop and have them ...
      (rec.autos.makers.ford.mustang)
    • Re: Head bolt sheared -- how to get out
      ... > of the bolts sheared. ... I would have used a regular socket on my impact wrench, ... You can normally take your head to a machine shop and have them ...
      (rec.autos.makers.ford.mustang)