Re: netgraph only on i386/ia64 - why ?

From: John Polstra (jdp_at_polstra.com)
Date: 08/18/04

  • Next message: Scott Long: "Re: netgraph only on i386/ia64 - why ?"
    Date: Wed, 18 Aug 2004 11:24:51 -0700 (PDT)
    To: Julian Elischer <julian@elischer.org>
    
    

    On 18-Aug-2004 Julian Elischer wrote:
    > John Polstra wrote:
    >>
    >> There is one problem with netgraph on 64-bit platforms. The ng_msghdr
    >> struct is 52 bytes / 4-byte aligned (see ng_message.h). That means
    >> the message payload is not well-aligned for 64-bit platforms. It
    >> would be nice to fix that (and bump NG_VERSION, of course). Nobody
    >> ever guaranteed that the message payload would be aligned, but it
    >> makes things a lot more convenient.
    >
    > if we do this we should do it now so that we have a consistent ABI from 5.3 on..
    >
    > scott (et al), should we pad an extra 4 bytes in this now?
    > it's low/no risk, but better now than after 5.3 has been released..

    I'd really like to see this change happen. Julian, would it require
    bumping just NG_VERSION, or should NG_ABI_VERSION change too?

    John
    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"


  • Next message: Scott Long: "Re: netgraph only on i386/ia64 - why ?"

    Relevant Pages

    • Re: netgraph only on i386/ia64 - why ?
      ... Julian Elischer wrote: ... > John Polstra wrote: ... >> I dropped scottl and re from the cc list, ... No port will be compiled ...
      (freebsd-net)
    • Re: netgraph only on i386/ia64 - why ?
      ... On Wed, 18 Aug 2004, John Polstra wrote: ... JP>>> There is one problem with netgraph on 64-bit platforms. ... JP>>> the message payload is not well-aligned for 64-bit platforms. ...
      (freebsd-net)