Re: netgraph only on i386/ia64 - why ?
From: Harti Brandt (harti_at_freebsd.org)
Date: 08/18/04
- Previous message: Scott Long: "Re: netgraph only on i386/ia64 - why ?"
- In reply to: John Polstra: "Re: netgraph only on i386/ia64 - why ?"
- Next in thread: Julian Elischer: "Re: netgraph only on i386/ia64 - why ?"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 18 Aug 2004 20:30:58 +0200 (CEST) To: John Polstra <jdp@polstra.com>
On Wed, 18 Aug 2004, John Polstra wrote:
JP>On 18-Aug-2004 Julian Elischer wrote:
JP>> John Polstra wrote:
JP>>>
JP>>> There is one problem with netgraph on 64-bit platforms. The ng_msghdr
JP>>> struct is 52 bytes / 4-byte aligned (see ng_message.h). That means
JP>>> the message payload is not well-aligned for 64-bit platforms. It
JP>>> would be nice to fix that (and bump NG_VERSION, of course). Nobody
JP>>> ever guaranteed that the message payload would be aligned, but it
JP>>> makes things a lot more convenient.
JP>>
JP>> if we do this we should do it now so that we have a consistent ABI from 5.3 on..
JP>>
JP>> scott (et al), should we pad an extra 4 bytes in this now?
JP>> it's low/no risk, but better now than after 5.3 has been released..
JP>
JP>I'd really like to see this change happen. Julian, would it require
Yes. Please do it.
JP>bumping just NG_VERSION, or should NG_ABI_VERSION change too?
harti
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
- Previous message: Scott Long: "Re: netgraph only on i386/ia64 - why ?"
- In reply to: John Polstra: "Re: netgraph only on i386/ia64 - why ?"
- Next in thread: Julian Elischer: "Re: netgraph only on i386/ia64 - why ?"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
